Skip to content

use :large_green_circle: for outgoing #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
+12 −12
Merged

use :large_green_circle: for outgoing #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/home/ui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ func BuildPRSections(incoming, outgoing []PR) []slack.Block {
var indicator string
switch {
case prs[i].NeedsReview:
indicator = ":red_circle:"
indicator = ":large_red_circle:"
case prs[i].IsBlocked:
indicator = ":red_circle:"
indicator = ":large_red_circle:"
case prs[i].ActionKind != "":
indicator = ":speech_balloon:"
default:
Expand Down Expand Up @@ -207,9 +207,9 @@ func BuildPRSections(incoming, outgoing []PR) []slack.Block {
var indicator string
switch {
case prs[i].NeedsReview:
indicator = ":green_circle:"
indicator = ":large_green_circle:"
case prs[i].IsBlocked:
indicator = ":green_circle:"
indicator = ":large_green_circle:"
case prs[i].ActionKind != "":
indicator = ":speech_balloon:"
default:
Expand Down
16 changes: 8 additions & 8 deletions pkg/home/ui_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,13 @@ func TestBuildBlocks(t *testing.T) {
foundBlockedPR := false
for _, block := range blocks {
if sb, ok := block.(*slack.SectionBlock); ok {
if sb.Text != nil && strings.Contains(sb.Text.Text, ":red_circle:") {
if sb.Text != nil && strings.Contains(sb.Text.Text, ":large_red_circle:") {
foundBlockedPR = true
}
}
}
if !foundBlockedPR {
t.Error("expected PR with :red_circle: indicating blocked incoming PR")
t.Error("expected PR with :large_red_circle: indicating blocked incoming PR")
}
},
},
Expand Down Expand Up @@ -195,13 +195,13 @@ func TestBuildBlocks(t *testing.T) {
foundBlocked := false
for _, block := range blocks {
if sb, ok := block.(*slack.SectionBlock); ok {
if sb.Text != nil && strings.Contains(sb.Text.Text, ":green_circle:") {
if sb.Text != nil && strings.Contains(sb.Text.Text, ":large_green_circle:") {
foundBlocked = true
}
}
}
if !foundBlocked {
t.Error("expected PR with :green_circle: for blocked outgoing PR")
t.Error("expected PR with :large_green_circle: for blocked outgoing PR")
}
},
},
Expand Down Expand Up @@ -410,10 +410,10 @@ func TestBuildPRSections_SortOrder(t *testing.T) {
}

// Verify color indicators
if !strings.Contains(incomingText, ":red_circle:") {
t.Error("incoming blocked PRs should use :red_circle:")
if !strings.Contains(incomingText, ":large_red_circle:") {
t.Error("incoming blocked PRs should use :large_red_circle:")
}
if !strings.Contains(outgoingText, ":green_circle:") {
t.Error("outgoing blocked PRs should use :green_circle:")
if !strings.Contains(outgoingText, ":large_green_circle:") {
t.Error("outgoing blocked PRs should use :large_green_circle:")
}
}
Loading