fix(version): fix bug from using app-root-path inside a node_module

Author: codeandcats

README.md

@@ -190,14 +190,28 @@ Session will be kept alive for 7 days
 
 
 ## Specifying the version
-By default classy-commander will report the version stored in your the `package.json`, or you can optionally specify your own.
+There are two ways to specify the version of your CLI:
+
+Using the version in your `package.json`
+
+```typescript
+import * as commander from 'classy-commander';
+
+...
+
+commander
+  .versionFromPackage(__dirname)
+  .execute();
+```
+
+Or manually
 
 ```typescript
 import * as commander from 'classy-commander';
 
 ...
 
 commander
-  .version('1.0.1')
+  .version('1.3.1')
   .execute();
 ```

package-lock.json

@@ -41,7 +41,6 @@
     "@commitlint/cli": "^7.1.2",
     "@commitlint/config-conventional": "^7.1.2",
     "@commitlint/prompt-cli": "^7.1.2",
-    "@types/app-root-path": "^1.2.4",
     "@types/fs-extra": "^5.0.4",
     "@types/jest": "^23.3.2",
     "jest": "^23.6.0",
@@ -54,7 +53,6 @@
     "typescript": "^3.0.3"
   },
   "dependencies": {
-    "app-root-path": "^2.1.0",
     "chalk": "^2.4.1",
     "commander": "^2.18.0",
     "fs-extra": "^7.0.0",

package.json

@@ -1,7 +1,7 @@
 // tslint:disable:no-console
-import * as root from 'app-root-path';
 import * as cli from 'commander';
 import * as fs from 'fs-extra';
+import * as path from 'path';
 import { setIocContainer } from './commander';
 import { IocContainer } from './types';
 
@@ -18,8 +18,15 @@ export class Commander {
     return this;
   }
 
+  public versionFromPackage(dirName: string): this {
+    this._version = this.getPackageVersion(path.resolve(dirName, './package.json'));
+    return this;
+  }
+
   public async execute(argv?: string[]): Promise<void> {
-    await this.setVersion();
+    if (this._version) {
+      cli.version(this._version);
+    }
 
     const args = argv || process.argv;
 
@@ -30,25 +37,11 @@ export class Commander {
     cli.parse(args);
   }
 
-  private async getPackageVersion(): Promise<string | undefined> {
-    const packageFileName = root.resolve('package.json');
-    if (!await fs.pathExists(packageFileName)) {
+  private getPackageVersion(packageFileName: string): string | undefined {
+    if (!fs.pathExistsSync(packageFileName)) {
       return undefined;
     }
-
-    const packageObject = await fs.readJSON(packageFileName);
-
+    const packageObject = fs.readJSONSync(packageFileName);
     return packageObject && packageObject.version;
   }
-
-  private async setVersion() {
-    const version =
-      this._version !== undefined ?
-        this._version :
-        await this.getPackageVersion();
-
-    if (version) {
-      cli.version(version);
-    }
-  }
 }