Skip to content

Conversation

@StanBarrows
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 10, 2025 09:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes constructor property promotion syntax across all Request classes by correcting the order of visibility and readonly modifiers. In PHP, visibility modifiers (public, protected, private) must come before the readonly keyword in constructor property promotion.

  • Corrects invalid readonly (implicitly public) to explicit public readonly
  • Corrects invalid readonly protected to valid protected readonly

Reviewed Changes

Copilot reviewed 115 out of 115 changed files in this pull request and generated no comments.

Show a summary per file
File Description
All VatPeriods Request files Fixed constructor property visibility syntax
All Users Request files Fixed constructor property visibility syntax
All Units Request files Fixed constructor property visibility syntax
All Titles Request files Fixed constructor property visibility syntax
All Taxes Request files Fixed constructor property visibility syntax
All Salutations Request files Fixed constructor property visibility syntax
All Reports Request files Fixed constructor property visibility syntax
All QrPayments Request files Fixed constructor property visibility syntax
All Projects Request files Fixed constructor property visibility syntax
All Payments Request files Fixed constructor property visibility syntax
All PaymentTypes Request files Fixed constructor property visibility syntax
All Notes Request files Fixed constructor property visibility syntax
All ManualEntries Request files Fixed constructor property visibility syntax
All Languages Request files Fixed constructor property visibility syntax
All Invoices Request files Fixed constructor property visibility syntax
All IbanPayments Request files Fixed constructor property visibility syntax
All Files Request files Fixed constructor property visibility syntax
All DocumentSettings Request files Fixed constructor property visibility syntax
All Currencies Request files Fixed constructor property visibility syntax
All Contacts Request files Fixed constructor property visibility syntax
All ContactSectors Request files Fixed constructor property visibility syntax
All ContactRelations Request files Fixed constructor property visibility syntax
All ContactGroups Request files Fixed constructor property visibility syntax
All ContactAdditionalAddresses Request files Fixed constructor property visibility syntax
All CompanyProfiles Request files Fixed constructor property visibility syntax
All CalendarYears Request files Fixed constructor property visibility syntax
All BusinessYears Request files Fixed constructor property visibility syntax
All BusinessActivities Request files Fixed constructor property visibility syntax
All BankAccounts Request files Fixed constructor property visibility syntax
All AdditionalAddresses Request files Fixed constructor property visibility syntax
All Accounts Request files Fixed constructor property visibility syntax
All AccountGroups Request files Fixed constructor property visibility syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StanBarrows StanBarrows merged commit a4dbc2f into main Nov 10, 2025
33 checks passed
@StanBarrows StanBarrows deleted the feature-contacts-v2 branch November 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants