Updated changelog.md + update ContactAdditionalAddress #49
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated ContactAdditionalAddresses functionality in favor of the existing AdditionalAddresses implementation, which provides the same capabilities with an enhanced field structure. The change also standardizes parameter naming across the codebase.
- Removed all
ContactAdditionalAddressesrequest classes, DTOs, tests, and fixtures - Standardized parameter naming from
idtocontactIdinAdditionalAddressesrequests - Updated documentation to reflect the migration path and new field structure
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Requests/ContactAdditionalAddresses/*.php | Removed 6 test files for deprecated ContactAdditionalAddresses requests |
| tests/Fixtures/Saloon/ContactAdditionalAddresses/*.json | Removed 6 fixture files for deprecated functionality |
| src/Requests/ContactAdditionalAddresses/*.php | Removed 6 request classes for deprecated functionality |
| src/Dto/ContactAdditionalAddresses/*.php | Removed 2 DTO classes for deprecated functionality |
| tests/Requests/AdditionalAddresses/*.php | Updated parameter from id to contactId for consistency |
| src/Requests/AdditionalAddresses/*.php | Updated parameter from id to contactId for consistency |
| README.md | Updated documentation with migration guide and new examples using enhanced field structure |
| CHANGELOG.md | Documented breaking changes and migration path |
| .phpunit.cache/test-results | Updated test execution results |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $additionalAddress = $connector->send(new CreateAnAdditionalAddressRequest( | ||
| contactId: 1, | ||
| data: new CreateEditContactAdditionalAddressDTO( | ||
| data: new CreateEditAdditionalAddressDTO( | ||
| name: 'Test', | ||
| subject: 'Test Subject', | ||
| description: 'This is a test', | ||
| address: 'Test Address', | ||
| postcode: '1234', | ||
| street_name: 'Main Street', | ||
| house_number: '123', | ||
| address_addition: 'Apt 4B', | ||
| postcode: 1234, | ||
| city: 'Test City', | ||
| ) | ||
| )); |
There was a problem hiding this comment.
The example is missing the required name_addition parameter for CreateEditAdditionalAddressDTO. According to the DTO definition, name_addition is a required parameter (not nullable). Add name_addition: null, or provide a value after the name parameter to match the DTO constructor signature.
| $additionalAddress = $connector->send(new EditAnAdditionalAddressRequest( | ||
| contactId: 1, | ||
| id: 9, | ||
| data: new CreateEditContactAdditionalAddressDTO( | ||
| data: new CreateEditAdditionalAddressDTO( | ||
| name: 'Test Edit', | ||
| subject: 'Test Subject Edit', | ||
| description: 'This is a test edit', | ||
| address: 'Test Address Edit', | ||
| postcode: '4567', | ||
| street_name: 'Main Street', | ||
| house_number: '456', | ||
| address_addition: 'Suite 2', | ||
| postcode: 4567, | ||
| city: 'Test City Edit', | ||
| ) | ||
| )); |
There was a problem hiding this comment.
The example is missing the required name_addition parameter for CreateEditAdditionalAddressDTO. According to the DTO definition, name_addition is a required parameter (not nullable). Add name_addition: null, or provide a value after the name parameter to match the DTO constructor signature.
No description provided.