Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@StanBarrows
Copy link
Contributor

No description provided.

@StanBarrows
Copy link
Contributor Author

@CasperLaiTW

Sorry. I've somehow messed something up with your permission. I've sent you an admin invite again.

I've also updated PHP 8.0 support.

Cheers
Sebastian

@StanBarrows StanBarrows changed the title Feature php 8 support added php 8 support Feb 9, 2021
@StanBarrows StanBarrows added the enhancement New feature or request label Feb 9, 2021
@codecov-io
Copy link

codecov-io commented Feb 9, 2021

Codecov Report

Merging #22 (ddc78de) into master (0950f57) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     81.60%   81.81%   +0.20%     
  Complexity       38       38              
============================================
  Files             2        2              
  Lines            87       88       +1     
============================================
+ Hits             71       72       +1     
  Misses           16       16              
Flag Coverage Δ Complexity Δ
L6 81.60% <ø> (ø) 0.00 <ø> (ø)
L7 81.60% <ø> (ø) 0.00 <ø> (ø)
L8 81.81% <ø> (+0.20%) 0.00 <ø> (ø)
P7.2 81.60% <ø> (ø) 0.00 <ø> (ø)
P7.3 81.60% <ø> (ø) 0.00 <ø> (ø)
P7.4 81.60% <ø> (ø) 0.00 <ø> (ø)
P8 81.81% <ø> (?) 0.00 <ø> (?)
prefer-lowest 81.60% <ø> (ø) 0.00 <ø> (ø)
prefer-stable 81.81% <ø> (+0.20%) 0.00 <ø> (ø)
ubuntu-latest 81.81% <ø> (+0.20%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/PrerenderMiddleware.php 79.74% <0.00%> (+0.25%) 35.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0950f57...ddc78de. Read the comment docs.

Copy link

@wireless25 wireless25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

@wireless25 wireless25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@StanBarrows StanBarrows merged commit 1ffb739 into master Feb 9, 2021
@CasperLaiTW
Copy link
Contributor

easy!

@ruslansteiger ruslansteiger deleted the feature-php-8-support branch April 28, 2021 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants