[WIP] chapter with basic layer of testing #1079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using subject(:chapter) where possible
- trying is_expected.to it can automatically be changed by
Rubocop
- validating all attributes as required on model
- slug is an on save test - explicit save! and reload before
testing again
- scope tests only need one object of each type and see if it
is allowed or denied
- mystery
- method available_to_user
- not sure if we need a URL safe slug or not but it isn't
being enforced
notapatch
changed the title
Contributor
Author
|
The refactoring of tests can wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll wait on @yihyang pull request #1069 - by eye I haven't seen any merge conflict but I want to keep things easy.
using subject(:chapter) where possible
trying is_expected.to it can automatically be changed by
Rubocop
validating all attributes as required on model
slug is an on save test - explicit save! and reload before
testing again
scope tests only need one object of each type and see if it
is allowed or denied
mystery
being enforced
And, coverall, like one word in production code removed. I'm hoping for at least +0.001% increase in coverage fingers crossed