Change Dockerfile to install google-chrome-stable #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notapatch
force-pushed
the
pr-google-chrome-stable
branch
from
fd1a873 to
71d6849
Compare
This was referenced Nov 3, 2019
Contributor
Author
|
@matyikriszta - ready for review - turns out we've been installing the wrong version of Chrome - the unstable rather than stable. This would then break the tests when running them in Docker depending on the release cycle of Chrome. Details in the commit. Thank you @jhsu802701 for reporting the issue |
- change google chrome to current version instead of an unstable newer version (+2 over current) - currently - stable chrome is 78 - unstable chrome is 80 - depending on where we are in the chrome release cycle the drivers may not work.
notapatch
force-pushed
the
pr-google-chrome-stable
branch
from
71d6849 to
4ab55ef
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144
We require ChromeDriver to run our browser tests. This is currently installed by Chromedriver helper which by default installs the latest driver.
New ChromeDrivers are released when Chrome goes beta - See image below:
So, as of today Chrome 79 is in beta and this is the latest driver. However, Planner’s Docker image installs the pre-beta, unstable, Chrome 80 version.
We are installing a Chrome version, 80, that has no chromedriver. When we run tests they fail. Saying we don't support this version of Chrome:
This change installs Stable which will be covered by Chromedriver.