Skip to content

Conversation

@matyikriszta
Copy link
Contributor

@matyikriszta matyikriszta commented Apr 24, 2021

Description

This PR fixes the layout issues within the Coaches and Organisers grids on the event page. It also replaces the Organisers grid with the organisers_grid partial. It also removes the Foundation magellan code that was left in there, Bootstrap doesn't have a magellan feature.

Status

Ready for Review

Related Github issues

Fixes #1508
Fixes #1509

Screenshots

Event page Coaches & Organisers grid Before Event page Coaches & Organisers grid After
Screenshot 2021-04-24 at 2 11 41 pm Screenshot 2021-04-24 at 2 10 21 pm

@matyikriszta matyikriszta changed the base branch from master to staging-remove-foundation-replace-with-bootstrap April 24, 2021 21:12
@gnclmorais gnclmorais self-requested a review April 24, 2021 21:15
Copy link
Contributor

@gnclmorais gnclmorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@matyikriszta matyikriszta changed the title Fix event page Coachs and Organisers grid layout bugs Fix event page Coaches and Organisers grid layout bugs Apr 25, 2021
@despo despo merged commit 4bb9a52 into staging-remove-foundation-replace-with-bootstrap Apr 28, 2021
@despo despo deleted the fix/event-page-layout-bugs branch April 28, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coaches grid layout on event page is broken Organisers grid layout on event page is broken

4 participants