Update /sponsors page to use shared sponsors partial #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyikriszta
force-pushed
the
improvement/update-sponsors-page-to-use-sponsors-partial
branch
from
e336c88 to
eb804b2
Compare
matyikriszta
changed the base branch from
master
to
staging-remove-foundation-replace-with-bootstrap
gnclmorais
approved these changes
May 8, 2021
| - grouped_sponsors.compact.each do |sponsor| | ||
| .medium-2.small-4.columns.sponsor-image | ||
| = link_to image_tag(sponsor.avatar, class: "small-image", alt: sponsor.name), sponsor.website | ||
| = render partial: 'shared/sponsors', object: @sponsor_levels[level].compact |
Contributor
There was a problem hiding this comment.
Nice spot! If you want to take this one step further, I noticed that app/views/chapter/show.html.haml could br DRYed up as well using this partial…
Contributor
Author
There was a problem hiding this comment.
@gnclmorais yep, it's coming up in a future PR
matyikriszta
merged commit e44ba5a
into
staging-remove-foundation-replace-with-bootstrap
matyikriszta
deleted the
improvement/update-sponsors-page-to-use-sponsors-partial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the sponsors index view to use the shared sponsors partial.
Status
Ready for Review
Related Github issue
Fixes #1523
Screenshots