Skip to content

Conversation

@KimberleyCook
Copy link
Contributor

Bootstrap member admin area.

Although mainly doing this page because it is broken and we've had feedback from organisers but, when the redesign was added a few months back one bit that is missing which I used often was what the student had worked on during their workshops. I checked this often before chatting with someone to understand what work they had been doing during the workshops.

Before After
screencapture-localhost-3001-admin-members-574-2021-10-26-16_12_15 screencapture-localhost-3001-admin-members-574-2021-10-26-16_11_00
Before After
screencapture-localhost-3001-admin-members-574-events-2021-10-26-16_12_05 screencapture-localhost-3001-admin-members-574-events-2021-10-26-16_11_16

@KimberleyCook KimberleyCook force-pushed the bootstrap-member-admin-page branch from f2857b8 to 3ec405d Compare October 26, 2021 14:20
@KimberleyCook KimberleyCook mentioned this pull request Oct 27, 2021
7 tasks
@KimberleyCook KimberleyCook force-pushed the bootstrap-member-admin-page branch 2 times, most recently from ec007e1 to 001a0e3 Compare October 27, 2021 16:53
@KimberleyCook KimberleyCook force-pushed the bootstrap-member-admin-page branch from 001a0e3 to 981a63d Compare October 27, 2021 17:02
@gnclmorais
Copy link
Contributor

Regarding the test that is failing:

  1) Admin managing members Admin managing members can view a summary of member event attendances
     Failure/Error: expect(page).to have_content('1 workshops')
       expected to find text "1 workshops" in "Attendance summary\n1\nworkshops". (However, it was found 1 time including non-visible text.)
     # ./spec/features/admin/members_spec.rb:24:in `block (4 levels) in <top (required)>'
     # ./spec/features/admin/members_spec.rb:23:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:98:in `block (2 levels) in <top (required)>'

The whitespace separating the 1 from workshop seems to have changed from a space to a line break… One way to fix it is to adapt the test that being a bit more permissive with whitespace:

diff --git a/spec/features/admin/members_spec.rb b/spec/features/admin/members_spec.rb
index 70a082f1..e0292a5a 100644
--- a/spec/features/admin/members_spec.rb
+++ b/spec/features/admin/members_spec.rb
@@ -21,7 +21,7 @@ RSpec.describe 'Admin managing members', type: :feature do
 
     it 'can view a summary of member event attendances' do
       within '.attendance-summary' do
-        expect(page).to have_content('1 workshops')
+        expect(page).to have_content('1 workshops', normalize_ws: true)
       end
     end

@KimberleyCook
Copy link
Contributor Author

thanks @gnclmorais, I'll update the PR today

@KimberleyCook
Copy link
Contributor Author

@matyikriszta cheers, feedback done.

@KimberleyCook KimberleyCook merged commit 05f6d94 into master Nov 9, 2021
@KimberleyCook KimberleyCook deleted the bootstrap-member-admin-page branch November 9, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants