-
-
Notifications
You must be signed in to change notification settings - Fork 198
Bootstrap member admin page #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2857b8 to
3ec405d
Compare
7 tasks
ec007e1 to
001a0e3
Compare
001a0e3 to
981a63d
Compare
Contributor
|
Regarding the test that is failing: The whitespace separating the diff --git a/spec/features/admin/members_spec.rb b/spec/features/admin/members_spec.rb
index 70a082f1..e0292a5a 100644
--- a/spec/features/admin/members_spec.rb
+++ b/spec/features/admin/members_spec.rb
@@ -21,7 +21,7 @@ RSpec.describe 'Admin managing members', type: :feature do
it 'can view a summary of member event attendances' do
within '.attendance-summary' do
- expect(page).to have_content('1 workshops')
+ expect(page).to have_content('1 workshops', normalize_ws: true)
end
end |
Contributor
Author
|
thanks @gnclmorais, I'll update the PR today |
matyikriszta
reviewed
Nov 4, 2021
matyikriszta
reviewed
Nov 4, 2021
matyikriszta
reviewed
Nov 4, 2021
Contributor
Author
|
@matyikriszta cheers, feedback done. |
matyikriszta
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap member admin area.
Although mainly doing this page because it is broken and we've had feedback from organisers but, when the redesign was added a few months back one bit that is missing which I used often was what the student had worked on during their workshops. I checked this often before chatting with someone to understand what work they had been doing during the workshops.