Fix Rollbar warning #521 - ActionController::RoutingError: No route matches [GET] "/images/logo-square.png" #1987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionController::RoutingError: No route matches [GET] '/images/logo-square.png'
matyikriszta
force-pushed
the
fix-rollbar-warning-521-missing-logo-image
branch
from
7404195 to
1e38ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we upgraded to Rails 7 we moved some assets around and the logo-square.png asset was deleted from public/images, but we forgot to update the reference to this image in that location in the app/views/layouts/_meta.html.haml file. The og:image meta tag is still looking for this image in that location. Update the og:image tag to serve the image from the asset pipeline instead. This fix should get rid of a warning in Rollbar with a large amount of occurrences.
Status
Ready for Review
Related Rollbar error/warning
https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/521