Fix Rollbar waring #521: missing Twitter summary image #1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
approved these changes
Dec 8, 2023
matyikriszta
deleted the
fix-rollbar-warning-521-missing-twitter-summary-image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we upgraded to Rails 7 we moved some assets around. The twitter-summary-card-image.png image was deleted from public/images and moved into assets/images/ but we forgot to update the references to the image. Update the asset path everywhere this image is used to point to the assets folder.
Status
Ready for Review
Related Rollbar error/warning
https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/521