Record organisers’ overrides #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnclmorais
force-pushed
the
record-overrides-with-id
branch
4 times, most recently
from
9fb64a0 to
43dec15
Compare
Comparing with the right class will make sure the button that should be there will actually appear.
Students need a tutorial for this, but it makes no sense if an organiser is manually adding a person.
This will allow us to record the ID of the last organiser that overrode a WorkshopInvite. I gave it a thought about this and tried a few different approaches, but this seemed the best compromise. I’ve looked into keeping track of every change through a few gems, but this would only grow the DB without much advantage, I believe. I don’t think we need (at the moment, at least) a detailed record of all the changes. At its core, I’m just interested in knowing if a WorkshopInvitation has been “tampered with”. This should help us with that.
gnclmorais
force-pushed
the
record-overrides-with-id
branch
from
86a71cf to
6563a13
Compare
gnclmorais
commented
Jan 1, 2024
gnclmorais
force-pushed
the
record-overrides-with-id
branch
from
6563a13 to
4b42153
Compare
Now the admin page of a workshop will display a different icon and message if an invite has been manually edited by an organiser.
This action no longer triggers an error, so let’s update the test.
gnclmorais
force-pushed
the
record-overrides-with-id
branch
from
4b42153 to
4bfb17e
Compare
matyikriszta
reviewed
Jan 6, 2024
matyikriszta
reviewed
Jan 6, 2024
matyikriszta
reviewed
Jan 6, 2024
There was a problem hiding this comment.
@gnclmorais code looks good overall, noticed two small typos. Going to check the changes out and test locally before I approve.
matyikriszta
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
@gnclmorais I've reviewed this locally and all looks good! Once those two typos are fixed this is good to ship 🚢
|
Thanks for fixing the typos! Sorry it took me a while to get back to this… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an organiser, I’ve ran into situations where I believe an invite or two has been edited by another organiser, but I don’t have a way to know. I’ve also had a student or two telling me they’ve received the attendance email, but their names are not on the list.
Hopefully, this PR will help with it. Now, whenever an organiser adds/removes a person from a workshop, we record their ID so we can connect that editing with their action. This is not the most exact method, but it saves us from recording every single change or creating a table just for this.
Bonus: this PR also addresses a few other things I found:
better_errorsgem to work its magic