Remove PhantomJS/Poltergeist as currently unused #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no feature tests which currently use `js: true`. The only one that needs it (in `spec/features/admin/manage_workshop_attendances_spec.rb`) is currently skipped, and also doesn't work with the current Poltergeist/PhantomJS setup anyway. PhantomJS is currently unmaintained: ariya/phantomjs#15105 (comment). It looks like the next thing to do is to look into using headless Chrome, which will be addressed in a future PR.
spike01
force-pushed
the
remove-poltergeist
branch
from
840ae87 to
2741adf
Compare
matyikriszta
approved these changes
Mar 6, 2019
Contributor
matyikriszta
left a comment
matyikriszta
left a comment
There was a problem hiding this comment.
Thanks @spike01, really happy to see this finally being addressed; it's been on my todo list for ages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no feature tests which currently use
js: true. The only onethat needs it (in
spec/features/admin/manage_workshop_attendances_spec.rb)is currently skipped, and also doesn't work with the current
Poltergeist/PhantomJS setup anyway.
PhantomJS is currently unmaintained:
ariya/phantomjs#15105 (comment).
It looks like the next thing to do is to look into using headless
Chrome, which will be addressed in a future PR.