Update copy for JS tutorial 2 #473
Merged
+32
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimberleyCook
requested review from
brunogirin,
despo,
gnclmorais and
matyikriszta
gnclmorais
approved these changes
May 8, 2021
KimberleyCook
force-pushed
the
update-copy-js-tutorial-2
branch
from
79cfd65 to
8c488d5
Compare
|
@gnclmorais thanks for your review, some great spots there 😅 |
|
@matyikriszta and @gnclmorais all your feedback has been implemented, let me know if you're happy for me to merge |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through and updated some bits of copy in the second JS tutorial. Removed the word just in many places too!
I also added a few more tasks to make it a bit more interactive and added an
Additional learningsection in the if/else statement section talking about ternaries. I added this as I think it is likely the most typical way if/else statements are written nowadays (plus it's up to date javascript). I still think showing the older way first is important but adding ternaries is important too for additional learning.