#672 fix lazy evaluation of page objects fields...#674
Merged
Conversation
…(index)` to achieve that, I added method `WebElementsCollection.getElements()` and made some of `WebElementsCollection` implementations cache the result of `getActualElements()`. it allowed me to remove field `actualElements` from `ElementsCollection`, `CollectionElement`, `SelenideElementIterator`. Thus method `ElementsCollection.get(index)` doesn't need to load the collection immediately, but just returns a "proxy" - `CollectionElement`.
Collaborator
|
Restart travise due error |
Collaborator
|
Some technical issues on travise today https://www.traviscistatus.com/ |
Member
|
LazyEvaluationTest added, which still fails. Hope it helps in fixing... |
Collaborator
Btw does test pass on 4.9? |
BorisOsipov
approved these changes
Jan 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… declared as
$$().get(index)to achieve that, I added method
WebElementsCollection.getElements()and made some of
WebElementsCollectionimplementations cache the result ofgetActualElements().it allowed me to remove field
actualElementsfromElementsCollection,CollectionElement,SelenideElementIterator.Thus method
ElementsCollection.get(index)doesn't need to load the collection immediately, but just returns a "proxy" -CollectionElement.Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Checklist
gradle check chrome htmlunitcommand