Javascript javascript1 week3 #5
Conversation
| function getNote(id) { | ||
| if (typeof id !== "number") { | ||
| console.log("Error: Invalid ID."); | ||
| return; |
There was a problem hiding this comment.
You can write here "return undefined" for clarity
| return; | |
| return undefined; |
And the error message can be made a little more specific (for example: "ID must be a number").
| const percentage = (seriesMinutes / lifespanInMinutes) * 100; | ||
| totalPercentage += percentage; | ||
|
|
||
| console.log(`${series.title} took ${percentage.toFixed(6)}% of your life.`); |
There was a problem hiding this comment.
Numbers with .toFixed(6) precision look too long
| days: 1, | ||
| hours: 0, | ||
| minutes: 9, | ||
| }, |
| @@ -0,0 +1,46 @@ | |||
| const seriesDurations = [ | |||
There was a problem hiding this comment.
If the series array is empty it will show 0%. Maybe add a check that if the array is empty, it will display for example, “There are no series”?
This is not necessary, but will make the code more reliable
| if (totalDuration >= usageLimit) { | ||
| console.log("You have reached your limit, no more smartphoning for you!"); | ||
| } | ||
|
|
|
|
||
|
|
||
| function addActivity(date, activity, duration) { | ||
| if (!date || !activity || !duration) { |
There was a problem hiding this comment.
The if (!date || !activity || !duration) prints a message, but does not stop the object from being added
| } | ||
|
|
||
|
|
||
| function showStatus() { |
There was a problem hiding this comment.
Due to undefined in duration, the reduce method produces NaN, which breaks the output. For example, the current code counts 30 + undefined + 40 + 40 = NaN
|
|
||
|
|
||
| function showStatus() { | ||
| if (activities.length == 0) { |
There was a problem hiding this comment.
| if (activities.length == 0) { | |
| if (activities.length === 0) { |
There was a problem hiding this comment.
Great job, your function calculates the time correctly and outputs “8 hours and 38 minutes”. The logic with Math.floor and Math.round for hours and minutes works perfectly
|
|
||
| const nameToRemove ="Ahmad" | ||
| const index = names.indexOf("Ahmad"); | ||
| if (name >-1){ |
There was a problem hiding this comment.
| if (name >-1){ | |
| if (index >-1){ |
Hello,
Please review my javascript-javascript1-week3 homework.
Thank you very much!