javascript1 week4 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great job Niña!
Remember to format your code as it is a good practice. Prettier should get the work done.
Comment on lines
+24
to
+30
| if (command.startsWith("Remove") && command.endsWith("from my todo")) { | ||
| let task = command.slice(7, -13). trim(); // Extract tasks from the command | ||
| let index = todos.indexOf(task); | ||
| if (index !== -1) { | ||
| todos.splice(index, 1); | ||
| return `Removed ${task} from your todo`; | ||
| } |
Comment on lines
+37
to
+39
| if (command === "What day is it today?") { | ||
| return new Date ().toDateString(); | ||
| } |
There was a problem hiding this comment.
Per the homework, you should format your date as expected.
(Should respond with the date in a human readable format. E.g. if today is 30/8/2019 then it should respond with 30. of August 2019)
Hint: toLocaleDateString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please review my Homework in javascript1 week4.
Thank you very much!