Refactor: update eslint and it's packages (#2112)

* chore: update eslint and it's packages

* refactor: fix eslint import/order rule errors

* refactor: fix eslint import/order rule errors in tests

* refactor: fix eslint errors

* refactor: fix eslint errors

* refactor: dsiable eslint arrow-parens rule

* refactor: skip max-classes-per-file eslint rule for step.js

* refactor: fix update errors

* refactor: update docs and typings

Author: elukoyanov

.eslintrc.json

@@ -37,6 +37,7 @@
     "import/no-unresolved": 0,
     "no-await-in-loop": 0,
     "arrow-body-style": 0,
-    "no-loop-func": 0
+    "no-loop-func": 0,
+    "arrow-parens": 0
   }
 }

examples/user_helper.js

@@ -1,5 +1,5 @@
-const Helper = require('../lib/helper');
 const assert = require('assert');
+const Helper = require('../lib/helper');
 
 class User extends Helper {
   // before/after hooks

lib/assert/error.js

@@ -11,9 +11,9 @@ function AssertionFailedError(params, template) {
   // this.message = "AssertionFailedError";
   let stack = new Error().stack;
   // this.showDiff = true;
-  stack = stack ? stack.split('\n').filter(line =>
-    // @todo cut assert things nicer
-    line.indexOf('lib/assert') < 0).join('\n') : '';
+
+  // @todo cut assert things nicer
+  stack = stack ? stack.split('\n').filter(line => line.indexOf('lib/assert') < 0).join('\n') : '';
   this.showDiff = true;
 
   this.actual = this.params.actual;

lib/codecept.js

@@ -1,13 +1,15 @@
-const fsPath = require('path');
+const existsSync = require('fs').existsSync;
 const readFileSync = require('fs').readFileSync;
+const glob = require('glob');
+const fsPath = require('path');
+const resolve = require('path').resolve;
+
 const container = require('./container');
 const Config = require('./config');
 const event = require('../lib/event');
-const glob = require('glob');
 const runHook = require('./hooks');
-const existsSync = require('fs').existsSync;
-const resolve = require('path').resolve;
 const output = require('./output');
+
 /**
  * CodeceptJS runner
  */

lib/command/configMigrate.js

@@ -1,15 +1,16 @@
-const print = require('../output').print;
-const success = require('../output').success;
-const error = require('../output').error;
 const colors = require('chalk');
 const fs = require('fs');
-const path = require('path');
-const fileExists = require('../utils').fileExists;
 const inquirer = require('inquirer');
-const getTestRoot = require('./utils').getTestRoot;
 const mkdirp = require('mkdirp');
+const path = require('path');
 const util = require('util');
 
+const print = require('../output').print;
+const success = require('../output').success;
+const error = require('../output').error;
+const fileExists = require('../utils').fileExists;
+const getTestRoot = require('./utils').getTestRoot;
+
 module.exports = function (initPath) {
   const testsPath = getTestRoot(initPath);
 

lib/command/definitions.js

@@ -1,10 +1,11 @@
+const fs = require('fs');
+const path = require('path');
+
 const getConfig = require('./utils').getConfig;
 const getTestRoot = require('./utils').getTestRoot;
 const Codecept = require('../codecept');
 const container = require('../container');
 const output = require('../output');
-const fs = require('fs');
-const path = require('path');
 
 const template = ({
   helperNames, supportObject, importPaths, translations, hasCustomStepsFile,

lib/command/generate.js

@@ -1,10 +1,11 @@
-const output = require('../output');
-const inquirer = require('inquirer');
+const colors = require('chalk');
 const fs = require('fs');
+const inquirer = require('inquirer');
+const mkdirp = require('mkdirp');
 const path = require('path');
-const colors = require('chalk');
+
 const { fileExists, ucfirst, lcfirst } = require('../utils');
-const mkdirp = require('mkdirp');
+const output = require('../output');
 const {
   getConfig, getTestRoot, safeFileWrite,
 } = require('./utils');

lib/command/gherkin/init.js

@@ -1,8 +1,9 @@
-const output = require('../../output');
 const inquirer = require('inquirer');
 const fs = require('fs');
 const path = require('path');
 const mkdirp = require('mkdirp');
+
+const output = require('../../output');
 const { fileExists, ucfirst, lcfirst } = require('../../utils');
 const {
   getConfig, getTestRoot, updateConfig, safeFileWrite,

lib/command/gherkin/snippets.js

@@ -1,14 +1,14 @@
+const escapeStringRegexp = require('escape-string-regexp');
+const fs = require('fs');
+const { Parser } = require('gherkin');
+const glob = require('glob');
+const fsPath = require('path');
+
 const getConfig = require('../utils').getConfig;
 const getTestRoot = require('../utils').getTestRoot;
 const Codecept = require('../../codecept');
-const container = require('../../container');
 const output = require('../../output');
 const { matchStep } = require('../../interfaces/bdd');
-const { Parser } = require('gherkin');
-const glob = require('glob');
-const fsPath = require('path');
-const fs = require('fs');
-const escapeStringRegexp = require('escape-string-regexp');
 
 const parser = new Parser();
 parser.stopAtFirstError = false;

lib/command/gherkin/steps.js

@@ -25,4 +25,3 @@ module.exports = function (genPath, options) {
     output.error('No Gherkin steps defined');
   }
 };
-