improve recorder a little: don't retry hooks (#2671)

* don't retry hooks

* fix tests

Co-authored-by: Mario Melcher <mario.melcher@seitenbau.com>

Author: nitschSB

lib/listener/helpers.js

@@ -23,7 +23,7 @@ module.exports = function () {
     if (store.dryRun) return;
     Object.keys(helpers).forEach((key) => {
       if (!helpers[key][hook]) return;
-      recorder.add(`hook ${key}.${hook}()`, () => helpers[key][hook](param), force);
+      recorder.add(`hook ${key}.${hook}()`, () => helpers[key][hook](param), force, false);
     });
   };
 

lib/recorder.js

@@ -154,17 +154,20 @@ module.exports = {
    * @param {string|function} taskName
    * @param {function} [fn]
    * @param {boolean} [force=false]
-   * @param {boolean} [retry=true] -
+   * @param {boolean} [retry]
+   *     undefined: `add(fn)` -> `false` and `add('step',fn)` -> `true`
    *     true: it will retries if `retryOpts` set.
    *     false: ignore `retryOpts` and won't retry.
    * @return {Promise<*> | undefined}
    * @inner
    */
-  add(taskName, fn = undefined, force = false, retry = true) {
+  add(taskName, fn = undefined, force = false, retry = undefined) {
     if (typeof taskName === 'function') {
       fn = taskName;
       taskName = fn.toString();
+      if (retry === undefined) retry = false;
     }
+    if (retry === undefined) retry = true;
     if (!running && !force) {
       return;
     }

test/unit/plugin/retryFailedStep_test.js

@@ -30,7 +30,7 @@ describe('retryFailedStep', () => {
       if (counter < 3) {
         throw new Error();
       }
-    });
+    }, undefined, undefined, true);
     return recorder.promise();
   });
   it('should not retry within', async () => {
@@ -44,7 +44,7 @@ describe('retryFailedStep', () => {
         recorder.add(() => {
           counter++;
           throw new Error();
-        });
+        }, undefined, undefined, true);
       });
       await recorder.promise();
     } catch (e) {
@@ -67,7 +67,7 @@ describe('retryFailedStep', () => {
         if (counter < 3) {
           throw new Error();
         }
-      });
+      }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
       recorder.catchWithoutStop((err) => err);
@@ -89,7 +89,7 @@ describe('retryFailedStep', () => {
         if (counter < 3) {
           throw new Error();
         }
-      });
+      }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
       recorder.catchWithoutStop((err) => err);
@@ -111,7 +111,7 @@ describe('retryFailedStep', () => {
         if (counter < 3) {
           throw new Error();
         }
-      });
+      }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
       recorder.catchWithoutStop((err) => err);
@@ -132,7 +132,7 @@ describe('retryFailedStep', () => {
         recorder.add(() => {
           counter++;
           throw new Error();
-        });
+        }, undefined, undefined, true);
       });
       await recorder.promise();
     } catch (e) {

test/unit/recorder_test.js

@@ -59,7 +59,7 @@ describe('Recorder', () => {
         if (counter < 3) {
           throw new Error('ups');
         }
-      });
+      }, undefined, undefined, true);
       return recorder.promise();
     });
 
@@ -74,7 +74,7 @@ describe('Recorder', () => {
         if (counter < 3) {
           throw new Error(errorText);
         }
-      });
+      }, undefined, undefined, true);
       return recorder.promise();
     });
   });