Skip to content

Commit 24bf12d

Browse files
DavertMikgalkin
authored andcommitted
[WIP] Refactoring (#800)
* refactored webdriverio * refactotred, updated selenium for travis tests * updated seleniumwebdriver & protractor * refactored * refactored Protractor helper * refactoring more * refactored and merged protractor and webdriver * codestyle fixes * refactored and fixed Nightmare * codestyles applied * fixed travis and added retries for tests * fixed Protractor codestyle * fixed Appium init * fixed Appium test * fixed tests * fixed appium execution * fixed fragile grabFromCssProperty test * fixed appium tests, improved error messages * added back patch to handle accessibility id * added EOL to locator * fixed locator detection in Appium * improved accessibility_id * fixed accessibilityId parsing * changed quick-second groups * fixed appium tests and locator * fixed parsing accessibility id * changed locator policy for accessid * returned back eslint rules * remocing import/no-unresolved rule. HoundCI can't run checks on it
1 parent ab77c26 commit 24bf12d

22 files changed

+4736
-6524
lines changed

.eslintrc.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
"default-case": 0,
3535
"import/no-extraneous-dependencies": 0,
3636
"no-cond-assign": 0,
37-
"array-callback-return": 0,
38-
"function-paren-newline": 0
37+
"import/no-unresolved": 0,
38+
"no-await-in-loop": 0,
39+
"arrow-body-style": 0
3940
}
4041
}

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ env:
1111
matrix:
1212
- HELPER=Protractor
1313
- HELPER=Nightmare
14-
- HELPER=SeleniumWebdriver
14+
- HELPER=ProtractorWeb
1515
- HELPER=WebDriverIO
1616
addons:
1717
apt:
@@ -20,9 +20,9 @@ addons:
2020
services:
2121
- docker
2222
before_install:
23-
- docker pull selenium/standalone-chrome:2.53.0
23+
- docker pull selenium/standalone-chrome:3.8
2424
before_script:
25-
- docker run -d --net=host selenium/standalone-chrome:2.53.0
25+
- docker run -d --net=host selenium/standalone-chrome:3.8
2626
- export DISPLAY=:99.0
2727
- sh -e /etc/init.d/xvfb start
2828
- chmod -R 777 test/data

examples/yahoo_test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
Feature('Yahoo test');
22

33
Scenario('Nightmare basic test', (I) => {
4-
I.amOnPage('http://yahoo.com');
4+
I.amOnPage('http://127.0.0.1:8000');
5+
pause();
56
I.fillField('p', 'github nightmare');
67
I.click('Search Web');
78
I.waitForElement('#main', 2);

0 commit comments

Comments
 (0)