Merge branch 'master' into codeceptjs-v3.0

Author: Mykhailo Bodnarchuk

.github/workflows/playwright.yml

@@ -44,3 +44,5 @@ jobs:
       run: "BROWSER=firefox node ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug"
     - name: run webkit tests
       run: "BROWSER=webkit node ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug"
+    - name: run unit tests
+      run: ./node_modules/.bin/mocha test/helper/Playwright_test.js

.travis.yml

@@ -13,7 +13,6 @@ env:
   - HELPER=ProtractorWeb
   - HELPER=WebDriver
   - HELPER=TestCafe
-  - HELPER=Playwright
 addons:
   apt:
     packages:

CHANGELOG.md

@@ -55,6 +55,9 @@ tryTo(() => I.click('Accept', '.cookies'));
 ```
 * **Possible breaking change** In semantic locators `[` char indicates CSS selector.
 
+## 2.6.4
+
+* [Playwright] **Playwright 1.0 support** by @Georgegriff.
 
 ## 2.6.3
 

Dockerfile

@@ -19,6 +19,7 @@ RUN apt-get update && apt-get install -y wget --no-install-recommends \
     && apt-get update \
     && apt-get install -y google-chrome-unstable \
       --no-install-recommends \
+    && apt-get install -y libgbm1 \
     && rm -rf /var/lib/apt/lists/* \
     && apt-get purge --auto-remove -y curl \
     && rm -rf /src/*.deb

docs/custom-helpers.md

@@ -210,7 +210,7 @@ async clickOnEveryElement(locator) {
 }
 ```
 
-In this case `el` will be an instance of [ElementHandle](https://github.com/microsoft/playwright/blob/v0.12.1/docs/api.md#class-elementhandle) which is similar for Playwright & [Puppeteer](https://pptr.dev/#?product=Puppeteer&version=v2.1.1&show=api-class-elementhandle).
+In this case `el` will be an instance of [ElementHandle](https://playwright.dev/#version=master&path=docs%2Fapi.md&q=class-elementhandle) which is similar for Playwright & [Puppeteer](https://pptr.dev/#?product=Puppeteer&version=master&show=api-class-elementhandle).
 
 > ℹ There are more `_locate*` methods in each helper. Take a look on documentation of a helper you use to see which exact method it exposes.
 

docs/helpers/Appium.md

@@ -1502,7 +1502,7 @@ I.seeInSource('<h1>Green eggs &amp; ham</h1>');
 ### grabSource
 
 Retrieves page source and returns it to test.
-Resumes test execution, so should be used inside an async function.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let pageSource = await I.grabSource();
@@ -1578,6 +1578,7 @@ I.seeAttributesOnElements('//form', { method: "post"});
 ### grabNumberOfVisibleElements
 
 Grab number of visible elements by locator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let numOfElements = await I.grabNumberOfVisibleElements('p');
@@ -1746,6 +1747,7 @@ I.switchTo(); // switch back to main page
 ### grabNumberOfOpenTabs
 
 Grab number of open tabs.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let tabs = await I.grabNumberOfOpenTabs();
@@ -1798,11 +1800,14 @@ I.setGeoLocation(121.21, 11.56, 10);
 ### grabGeoLocation
 
 Return the current geo location 
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let geoLocation = await I.grabGeoLocation();
 ```
 
+Returns **[Promise][13]&lt;{latitude: [number][8], longitude: [number][8], altitude: [number][8]}>** 
+
 ### grabElementBoundingRect
 
 Grab the width, height, location of given locator.

docs/helpers/Nightmare.md

@@ -454,7 +454,7 @@ Returns **[Promise][8]<[Array][10]<[string][3]>>** attribute value
 
 Gets a cookie object by name.
 If none provided gets all cookies.
-Resumes test execution, so **should be used inside async with `await`** operator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let cookie = await I.grabCookie('auth');
@@ -541,6 +541,7 @@ Returns **[Promise][8]<[Array][10]<[string][3]>>** HTML code for an elemen
 ### grabNumberOfVisibleElements
 
 Grab number of visible elements by locator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let numOfElements = await I.grabNumberOfVisibleElements('p');

docs/helpers/Playwright.md

@@ -19,9 +19,9 @@ Uses [Playwright][1] library to run tests inside:
 
 This helper works with a browser out of the box with no additional tools required to install.
 
-Requires `playwright` package version ^0.12.1 to be installed:
+Requires `playwright` package version ^1 to be installed:
 
-    npm i playwright@^0.12.1 --save
+    npm i playwright@^1 --save
 
 ## Configuration
 
@@ -38,7 +38,7 @@ This helper should be configured in codecept.json or codecept.conf.js
 -   `keepBrowserState`:  - keep browser state between tests when `restart` is set to false.
 -   `keepCookies`:  - keep cookies between tests when `restart` is set to false.
 -   `waitForAction`: (optional) how long to wait after click, doubleClick or PressKey actions in ms. Default: 100.
--   `waitForNavigation`: . When to consider navigation succeeded. Possible options: `load`, `domcontentloaded`, `networkidle0`, `networkidle2`. Choose one of those options is possible. See [Playwright API][2].
+-   `waitForNavigation`: . When to consider navigation succeeded. Possible options: `load`, `domcontentloaded`, `networkidle`. Choose one of those options is possible. See [Playwright API][2].
 -   `pressKeyDelay`: . Delay between key presses in ms. Used when calling Playwrights page.type(...) in fillField/appendField
 -   `getPageTimeout`  config option to set maximum navigation time in milliseconds.
 -   `waitForTimeout`: (optional) default wait* timeout in ms. Default: 1000.
@@ -698,7 +698,7 @@ Returns **[Promise][9]<[Array][10]<any>>**
 
 Gets a cookie object by name.
 If none provided gets all cookies.
-Resumes test execution, so **should be used inside async with `await`** operator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let cookie = await I.grabCookie('auth');
@@ -843,6 +843,7 @@ Returns **[Promise][9]<[Array][10]<[string][7]>>** HTML code for an elemen
 ### grabNumberOfOpenTabs
 
 Grab number of open tabs.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let tabs = await I.grabNumberOfOpenTabs();
@@ -853,6 +854,7 @@ Returns **[Promise][9]<[number][8]>** number of open tabs
 ### grabNumberOfVisibleElements
 
 Grab number of visible elements by locator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let numOfElements = await I.grabNumberOfVisibleElements('p');
@@ -888,7 +890,7 @@ Returns **[Promise][9]<([string][7] | null)>**
 ### grabSource
 
 Retrieves page source and returns it to test.
-Resumes test execution, so should be used inside an async function.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let pageSource = await I.grabSource();
@@ -1600,6 +1602,7 @@ I.waitForClickable('.btn.continue', 5); // wait for 5 secs
 #### Parameters
 
 -   `locator` **([string][7] | [object][5])** element located by CSS|XPath|strict locator.
+-   `waitTimeout`  
 -   `sec` **[number][8]?** (optional, `1` by default) time in seconds to wait
 
 ### waitForDetached
@@ -1852,7 +1855,7 @@ I.waitUrlEquals('http://127.0.0.1:8000/info');
 
 [11]: https://codecept.io/helpers/FileSystem
 
-[12]: https://github.com/microsoft/playwright/blob/v0.12.1/docs/api.md#browsernewpageoptions
+[12]: https://github.com/microsoft/playwright/blob/master/docs/api.md#browsernewpageoptions
 
 [13]: #fillfield
 

docs/helpers/Protractor.md

@@ -614,7 +614,7 @@ Returns **[Promise][13]<[Array][14]<any>>** all browser logs
 
 Gets a cookie object by name.
 If none provided gets all cookies.
-Resumes test execution, so **should be used inside async with `await`** operator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let cookie = await I.grabCookie('auth');
@@ -708,6 +708,7 @@ Returns **[Promise][13]<[Array][14]<[string][9]>>** HTML code for an eleme
 ### grabNumberOfOpenTabs
 
 Grab number of open tabs.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let tabs = await I.grabNumberOfOpenTabs();
@@ -718,6 +719,7 @@ Returns **[Promise][13]<[number][7]>** number of open tabs
 ### grabNumberOfVisibleElements
 
 Grab number of visible elements by locator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let numOfElements = await I.grabNumberOfVisibleElements('p');
@@ -751,7 +753,7 @@ await I.grabPopupText();
 ### grabSource
 
 Retrieves page source and returns it to test.
-Resumes test execution, so should be used inside an async function.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let pageSource = await I.grabSource();

docs/helpers/Puppeteer.md

@@ -788,7 +788,7 @@ Returns **[Promise][13]<[Array][14]<any>>**
 
 Gets a cookie object by name.
 If none provided gets all cookies.
-Resumes test execution, so **should be used inside async with `await`** operator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let cookie = await I.grabCookie('auth');
@@ -941,6 +941,7 @@ Returns **[Promise][13]<[Array][14]<[string][8]>>** HTML code for an eleme
 ### grabNumberOfOpenTabs
 
 Grab number of open tabs.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let tabs = await I.grabNumberOfOpenTabs();
@@ -951,6 +952,7 @@ Returns **[Promise][13]<[number][10]>** number of open tabs
 ### grabNumberOfVisibleElements
 
 Grab number of visible elements by locator.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let numOfElements = await I.grabNumberOfVisibleElements('p');
@@ -991,7 +993,7 @@ Returns **[Promise][13]<([string][8] | null)>**
 ### grabSource
 
 Retrieves page source and returns it to test.
-Resumes test execution, so should be used inside an async function.
+Resumes test execution, so **should be used inside async function with `await`** operator.
 
 ```js
 let pageSource = await I.grabSource();