Fix some eslint rules

Author: galkin

.eslintrc.json

@@ -23,33 +23,18 @@
     "prefer-rest-params": 0,
     "no-useless-escape": 0,
     "no-restricted-syntax": 0,
-    "one-var": 0,
     "no-unused-expressions": 0,
-    "eqeqeq": 0,
     "guard-for-in": 0,
     "no-multi-assign": 0,
     "require-yield": 0,
     "prefer-spread": 0,
-    "radix": 0,
     "import/no-dynamic-require": 0,
-    "prefer-const": 0,
-    "no-empty": 0,
     "no-continue": 0,
     "no-mixed-operators": 0,
     "default-case": 0,
     "import/no-extraneous-dependencies": 0,
-    "no-bitwise": 0,
-    "no-array-constructor": 0,
     "no-cond-assign": 0,
-    "no-var": 0,
-    "no-buffer-constructor": 0,
-    "no-eval": 0,
     "array-callback-return": 0,
-    "no-loop-func": 0,
-    "quotes": 0,
-    "import/no-unresolved": 0,
-    "no-redeclare": 0,
-    "function-paren-newline": 0,
-    "no-useless-return": 0
+    "function-paren-newline": 0
   }
 }

examples/pages/Admin.js

@@ -3,7 +3,7 @@ let I;
 module.exports = {
 
   _init() {
-    I = require('codeceptjs/actor')();
+    I = actor();
   },
 
   // insert your locators and methods here

lib/codecept.js

@@ -20,7 +20,7 @@ class Codecept {
   constructor(config, opts) {
     this.config = Config.create(config);
     this.opts = opts;
-    this.testFiles = new Array();
+    this.testFiles = [];
   }
 
   /**

lib/command/init.js

@@ -195,11 +195,9 @@ module.exports = function (initPath) {
     print('Configure helpers...');
     inquirer.prompt(helperConfigs, (helperResult) => {
       Object.keys(helperResult).forEach((key) => {
-        let helperName,
-          configName;
         const parts = key.split('_');
-        helperName = parts[0];
-        configName = parts[1];
+        const helperName = parts[0];
+        const configName = parts[1];
         if (!configName) return;
         config.helpers[helperName][configName] = helperResult[key];
       });

lib/command/run-multiple.js

@@ -9,8 +9,8 @@ const output = require('../output');
 const path = require('path');
 
 const runner = path.join(__dirname, '/../../bin/codecept');
-let config,
-  childOpts = {};
+let config;
+const childOpts = {};
 const copyOptions = ['steps', 'reporter', 'verbose', 'config', 'reporter-options', 'grep', 'fgrep', 'debug'];
 
 // codeceptjs run:multiple smoke:chrome regression:firefox - will launch smoke suite in chrome and regression in firefox

lib/command/run.js

@@ -13,8 +13,8 @@ module.exports = function (test, options) {
   // registering options globally to use in config
   process.profile = options.profile;
   const configFile = options.config;
-  let codecept,
-    outputDir;
+  let codecept;
+  let outputDir;
 
   const testRoot = getTestRoot(configFile);
   let config = getConfig(configFile);

lib/config.js

@@ -95,12 +95,12 @@ module.exports = Config;
 
 function loadConfigFile(configFile) {
   // .conf.js config file
-  if (path.extname(configFile) == '.js') {
+  if (path.extname(configFile) === '.js') {
     return Config.create(require(configFile).config);
   }
 
   // json config provided
-  if (path.extname(configFile) == '.json') {
+  if (path.extname(configFile) === '.json') {
     return Config.create(JSON.parse(fs.readFileSync(configFile, 'utf8')));
   }
   throw new Error(`Config file ${configFile} can't be loaded`);

lib/container.js

@@ -148,7 +148,7 @@ function createSupportObjects(config) {
   if (!objects.I) {
     objects.I = require('./actor')();
 
-    if (container.translation.I != 'I') {
+    if (container.translation.I !== 'I') {
       objects[container.translation.I] = objects.I;
     }
   }

lib/data/table.js

@@ -4,7 +4,7 @@
 class DataTable {
   constructor(array) {
     this.array = array;
-    this.rows = new Array();
+    this.rows = [];
   }
 
   add(array) {

lib/helper/Appium.js

@@ -1255,7 +1255,6 @@ function parseLocator(locator) {
 
 // in the end of a file
 function onlyForApps(expectedPlatform) {
-  let callerName;
   const stack = new Error().stack || '';
   const re = /Appium.(\w+)/g;
   const caller = stack.split('\n')[2].trim();
@@ -1265,7 +1264,7 @@ function onlyForApps(expectedPlatform) {
     throw new Error(`Invalid caller ${caller}`);
   }
 
-  callerName = m[1] || m[2];
+  const callerName = m[1] || m[2];
   if (!expectedPlatform) {
     if (!this.platform) {
       throw new Error(`${callerName} method can be used only with apps`);