Skip to content

fix(playwright): always use keyboard.type for strings, add national characters test #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

fix(playwright): always use keyboard.type for strings, add national characters test #5280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3408dc
fix(playwright): always use keyboard.type for strings, add national c…
mirao Oct 29, 2025
1dadfeb
fix(playwright): improved a comment (#5279)
mirao Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/helper/Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,11 +1876,15 @@ class Playwright extends Helper {
* {{> type }}
*/
async type(keys, delay = null) {
// Always use page.keyboard.type for any string (including single character and national characters).
if (!Array.isArray(keys)) {
keys = keys.toString()
keys = keys.split('')
const typeDelay = typeof delay === 'number' ? delay : this.options.pressKeyDelay
await this.page.keyboard.type(keys, { delay: typeDelay })
return
}

// For array input, treat each as a key press to keep working combinations such as ['Control', 'A'] or ['T', 'e', 's', 't'].
for (const key of keys) {
await this.page.keyboard.press(key)
if (delay) await this.wait(delay / 1000)
Expand Down
9 changes: 9 additions & 0 deletions test/helper/Playwright_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,15 @@ describe('Playwright', function () {
})
})

describe('#type', () => {
it('should type national characters', async () => {
await I.amOnPage('/form/field')
await I.fillField('Name', '')
await I.type('Oprávněné')
await I.seeInField('Name', 'Oprávněné')
})
})

describe('#waitForEnabled', () => {
it('should wait for input text field to be enabled', () =>
I.amOnPage('/form/wait_enabled')
Expand Down