Skip to content

Conversation

@dantevvp
Copy link
Contributor

@dantevvp dantevvp commented Feb 7, 2023

  • Change deploy logic to not push images to GCR. Instead, images will be deployed directly to Dockerhub. For this, we need to tag images both with the $CIRCLE_BUILD_NUM and the engine's channel.

@dantevvp dantevvp requested review from a team, bobpattersonjr and f-moya and removed request for a team February 8, 2023 15:08
@larkinscott
Copy link
Contributor

Will we need to login to dockerhub somewhere in the config or is there somewhere else we do that?

@dantevvp
Copy link
Contributor Author

dantevvp commented Feb 8, 2023

Will we need to login to dockerhub somewhere in the config or is there somewhere else we do that?

Yeah I believe so. To do that we can use the Quality context variables right?

@larkinscott
Copy link
Contributor

@dantevvp That's correct

@RubyBrewsday RubyBrewsday merged commit d1e1238 into master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants