Only use SexpLines for old parsers

Addresses codeclimate/app#6227.

Author: toddmazierski

lib/cc/engine/analyzers/analyzer_base.rb

@@ -90,6 +90,11 @@ def transform_sexp(sexp)
           sexp
         end
 
+        # Please see: codeclimate/app#6227
+        def use_sexp_lines?
+          true
+        end
+
         private
 
         attr_reader :engine_config

lib/cc/engine/analyzers/java/main.rb

@@ -20,6 +20,10 @@ class Main < CC::Engine::Analyzers::Base
           POINTS_PER_OVERAGE = 10_000
           REQUEST_PATH = "/java".freeze
 
+          def use_sexp_lines?
+            false
+          end
+
           private
 
           def process_file(file)

lib/cc/engine/analyzers/javascript/main.rb

@@ -20,6 +20,10 @@ class Main < CC::Engine::Analyzers::Base
           POINTS_PER_OVERAGE = 30_000
           REQUEST_PATH = "/javascript".freeze
 
+          def use_sexp_lines?
+            false
+          end
+
           private
 
           def process_file(file)

lib/cc/engine/analyzers/php/main.rb

@@ -23,6 +23,10 @@ def transform_sexp(sexp)
             delete_comments!(sexp)
           end
 
+          def use_sexp_lines?
+            false
+          end
+
           private
 
           def process_file(file)

lib/cc/engine/analyzers/violation.rb

@@ -85,14 +85,24 @@ def format_other_locations
         end
 
         def format_sexp(sexp)
-          lines = SexpLines.new(sexp)
-          {
-            "path": sexp.file.gsub(%r{^./}, ""),
-            "lines": {
-              "begin": lines.begin_line,
-              "end": lines.end_line,
-            },
-          }
+          if language_strategy.use_sexp_lines?
+            lines = SexpLines.new(sexp)
+            {
+              "path": sexp.file.gsub(%r{^./}, ""),
+              "lines": {
+                "begin": lines.begin_line,
+                "end": lines.end_line,
+              },
+            }
+          else
+            {
+              "path": sexp.file.gsub(%r{^./}, ""),
+              "lines": {
+                "begin": sexp.line,
+                "end": sexp.end_line,
+              },
+            }
+          end
         end
 
         def content_body

spec/cc/engine/analyzers/javascript/main_spec.rb

@@ -172,6 +172,35 @@
     expect(issues).to be_empty
   end
 
+  it "outputs the correct line numbers for ASTs missing line details (codeclimate/app#6227)" do
+    create_source_file("foo.js", <<~EOJS)
+      `/movie?${getQueryString({ movie_id: movieId })}`
+    EOJS
+
+    create_source_file("bar.js", <<~EOJS)
+      var greeting = "hello";
+
+      `/movie?${getQueryString({ movie_id: movieId })}`
+    EOJS
+
+    issues = run_engine(engine_conf).strip.split("\0")
+    expect(issues).to_not be_empty
+
+    issues.map! { |issue| JSON.parse(issue) }
+
+    foo_issue = issues.detect { |issue| issue.fetch("location").fetch("path") == "foo.js" }
+    expect(foo_issue["location"]).to eq({
+      "path" => "foo.js",
+      "lines" => { "begin" => 1, "end" => 1 },
+    })
+
+    bar_issue = issues.detect { |issue| issue.fetch("location").fetch("path") == "bar.js" }
+    expect(bar_issue["location"]).to eq({
+      "path" => "bar.js",
+      "lines" => { "begin" => 3, "end" => 3 },
+    })
+  end
+
   def engine_conf
     CC::Engine::Analyzers::EngineConfig.new({
       'config' => {

spec/cc/engine/analyzers/violations_spec.rb

@@ -5,7 +5,7 @@ module CC::Engine::Analyzers
     describe "#each" do
       let(:issue) { double(:issue, mass: 10, identical?: true) }
       let(:hashes) { sexps }
-      let(:language_strategy) { double(:language_strategy, calculate_points: 30, calculate_severity: CC::Engine::Analyzers::Base::MINOR) }
+      let(:language_strategy) { double(:language_strategy, calculate_points: 30, calculate_severity: CC::Engine::Analyzers::Base::MINOR, use_sexp_lines?: true) }
       let(:violations) { [] }
 
       before do