Skip to content

Conversation

@JiriChara
Copy link
Contributor

Hey,

I tried to build my repository on codeclimate and it seems like that eslint-plugin-vue and eslint-plugin-html is missing.

I hope this PR will fix the issue.

@dblandin
Copy link
Contributor

dblandin commented Mar 6, 2017

Hey @JiriChara ,

Thanks for the PR! Are there any category mappings to specify for these plugins?

https://github.com/codeclimate/codeclimate-eslint/blob/master/lib/check_category_mapping.json

Looks like this PR might also need a rebase.

@JiriChara
Copy link
Contributor Author

Hey @dblandin,

I have rebased to latest greatest master, but I am not sure if any category mappings are required. How can I find it out?

@dblandin
Copy link
Contributor

dblandin commented Mar 6, 2017

If the plugins only emits Style issues, which is the default, then you should be all set. If the plugins check for issues of complexity, clarity, security, etc, then some mappings would be beneficial.

Here's a list of the categories that the we currently support: https://github.com/codeclimate/spec/blob/master/SPEC.md#categories

@JiriChara
Copy link
Contributor Author

@dblandin both plugins are checking styling only right now. I think they would like to add check for unclosed tags, but it's not yet implemented.

@JiriChara
Copy link
Contributor Author

@dblandin Do you think we can get this merged?

@dblandin dblandin merged commit bcc8ddf into qltysh-archive:master Mar 8, 2017
@dblandin
Copy link
Contributor

dblandin commented Mar 8, 2017

@JiriChara FYI: I just released an update including the plugins from this PR. Should be available via the CLI and codeclimate.com now. Let me know if you run into any issues!

@JiriChara
Copy link
Contributor Author

@dblandin works like a charm. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants