ESlint 2.0 #92

pbrisbin · 2016-05-26T22:49:13Z

This is the branch we'll be deploying the eslint-2 channel from as we begin
initial testing of that image. It's #79 with some additional changes (see
individual commits) and anything we identify and address during testing.

More documentation about this change is on the way, but for anyone who
sees this PR and wants to use it, the engine can be opted into with:

engines:
  eslint:
    enabled: true
    channel: eslint-2

- Add access to ESLint docs - Add support for parametrized Docker builds, building different versions of the documentation - Automatically detect which version of the docs we should be including

Fixes: npm WARN eslint-config-airbnb@6.2.0 requires a peer of eslint@^2.4.0 but none was installed. npm WARN codeclimate-eslint@0.0.3 No license field. Cloning into 'eslint'... npm ERR! peer dep missing: eslint@^2.4.0, required by eslint-config-airbnb@6.2.0 npm ERR! code 1 error: pathspec 'vnull' did not match any file(s) known to git.

Fixes: /usr/src/app/node_modules/meld/meld.js:67 if (typeof target[pointcut] === 'function') { ^ TypeError: Cannot read property 'loadPackage' of undefined at meld (/usr/src/app/node_modules/meld/meld.js:67:23) at Function.around (/usr/src/app/node_modules/meld/meld.js:436:12) at patcher (/usr/src/app/lib/eslint-patch.js:21:8) at Object.<anonymous> (/usr/src/app/bin/eslint.js:11:44) at Module._compile (module.js:397:26) at Object.Module._extensions..js (module.js:404:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Function.Module.runMain (module.js:429:10) at startup (node.js:139:18)

Fixes #91

``` eslint@2.4.0 -> eslint@2.10.2 eslint-config-airbnb@6.0.2 -> eslint-config-airbnb@9.0.1 eslint-plugin-babel@2.1.1 -> eslint-config-airbnb@3.2.0 eslint-plugin-react@4.0.0 -> eslint-config-react@5.1.1 ```

Update dependencies

…lugin-config eslint-2: Support standard style ESLint shared config and plugin

…le-config eslint-2: Update CircleCI config to use patrick

chibicode · 2016-06-14T08:24:31Z

@jpignata @dblandin could we add eslint-config-standard-jsx to package.json as well? This is required for React developers (and this is included when you install standard).

dblandin · 2016-06-15T17:11:21Z

@chibicode Sounds good to me! I'll open up a PR to pull that in.

Many users using [Standard Style][] also use these configuration packages when writing React/JSX. [Standard Style]: https://github.com/feross/standard This commit vendors the [eslint-config-standard-react] and [eslint-config-standard-jsx] packages. [eslint-config-standard-react]: https://github.com/feross/eslint-config-standard-react [eslint-config-standard-jsx]: https://github.com/feross/eslint-config-standard-jsx

dblandin · 2016-06-20T23:11:46Z

Hey @chibicode,

I just pushed out a new engine image to the eslint-2 channel with support for the eslint-config-standard-react and eslint-config-standard-jsx configs.

Let me know if it works for you!

chibicode · 2016-06-21T10:09:53Z

@dblandin great, thank you!

Add eslint-config-google as available plugin

Add support for ESLint plugin Flowtype

Update package.json

eslint-2: Vendor eslint-plugin-angular package

By default we filter out minified files that are identifiable as minified from their filename (e.g. *.min.js), but many projects have minified files that don't match those patterns, and these files can cause ESLint to segfault in a container environment (possibly due to memory pressure). This adds a new heuristic filter based on line length that filters out files that appear to be minified to prevent them being analyzed. For any matching files, a log message is sent to stderr notifying that the file is being skipped.

Heuristically filter out minified files

…-ember add eslint-config-ember package

Related to #111, a Segfault occurs when we hammer STDOUT with issues. Switching from alpine to a debian-based image seems to behave better in this scenario.

Switch base image to avoid Segfault

We're a bit behind on these. Flowtype in particular has new rules we weren't supporting. Looks like we hadn't actually filled in the shrinkwrap file before now, either, so that's done.

Update babel-eslint & eslint-flowtype

- Update eslint configuration - Reduce complexity via temporary variable - Consistent brace style Extracted from #109

Makes it possible to use ignorePath from the CLIEngine. Useful when you are already ignoring the files you don't want to lint in different file (.e.g .gitignore).

hapi eslint config is based on eslint-config-hapi and eslint-plugin-hapi packages

add hapi config support

mhaylock · 2016-08-25T03:34:19Z

lib/eslint-patch.js

+
+module.exports = function patcher(eslint) {
+
+  meld.around(eslint.CLIEngine, 'loadPlugins', function(joinPoint) {


Is this patch working as intended? I arrived here because I'm seeing Failed to load plugin errors for an unsupported plugin, but I think this patch is intended to avoid loading unsupported plugins?

I'm questioning whether this does anything because it appears to me that eslint.CLIEngine has not had a loadPlugins method since this commit, and that commit has been around since ESLint 2.0.0?

This patch is not working as intended. It was at the time it was written, but (as you noted) that's no longer the case given the current internals of ESLint.

We're evaluating if we want to accept unsupported plugins causing errors like that, or try to bring back the logic intended to replace that with ignoring them. Unfortunately, this meld approach doesn't appear viable on the new internals, so it would require moving back to our own fork of ESLint itself.

In the meantime though, we should probably remove this.

EDIT: It may not have even worked when it was written. The history is uncertain here.

eslint-config-airbnb-base is a transitive dependency of eslint-config-airbnb, but it is useful in its own right and should be included at the top level such that it has proper support in the eslint engine.

Add eslint-config-airbnb-base as a top-level dep

dblandin · 2016-09-12T18:09:01Z

Hey everyone!

Development for the eslint-2 channel has moved to the channel/eslint-2 branch. That branch won't have a tracking PR. Instead, new PRs targeting the eslint-2 channel should be opened with a base of channel/eslint-2.

Also, if you're interested, we just released an eslint-3 channel!

Thanks!

Dan Rumney and others added 4 commits May 26, 2016 17:40

Monkey patch eslint, instead of modifying it

06b6503

- Add access to ESLint docs - Add support for parametrized Docker builds, building different versions of the documentation - Automatically detect which version of the docs we should be including

Update babel-eslint to v6

483a24d

Fixes #91

pbrisbin changed the title ~~Eslint 2.0~~ ESlint 2.0 May 26, 2016

This was referenced May 27, 2016

Monkey patch eslint, instead of modifying it #79

Closed

Merge ESlint:Master to upgrade! codeclimate/eslint#10

Closed

dblandin added 8 commits May 27, 2016 15:34

Update dependencies

d1ff631

``` eslint@2.4.0 -> eslint@2.10.2 eslint-config-airbnb@6.0.2 -> eslint-config-airbnb@9.0.1 eslint-plugin-babel@2.1.1 -> eslint-config-airbnb@3.2.0 eslint-plugin-react@4.0.0 -> eslint-config-react@5.1.1 ```

Merge pull request #93 from codeclimate/devon/eslint-2

70efbc9

Update dependencies

Add standard style plugin and shared config

20b0ede

COPY npm-shrinkwrap.json before npm install

5979e0f

Merge pull request #96 from codeclimate/devon/eslint-2-add-standard-p…

95911b8

…lugin-config eslint-2: Support standard style ESLint shared config and plugin

Update CircleCI config to use patrick

88215de

Cleanup Dockerfile

bfaa029

Merge pull request #98 from codeclimate/devon/pb-eslint-2-update-circ…

e2dcac7

…le-config eslint-2: Update CircleCI config to use patrick

dblandin mentioned this pull request Jun 15, 2016

Lack of eslint-2 plugin and standards support #100

Closed

pbrisbin and others added 9 commits July 15, 2016 10:13

Add eslint-config-google as available plugin

beefd30

Merge pull request #104 from codeclimate/pb-google-config

df907bc

Add eslint-config-google as available plugin

Added supporto for ESLint plugin Flowtype

833aa19

Merge pull request #106 from favoloso/eslint-2-flowtype-plugin

31e828e

Add support for ESLint plugin Flowtype

Add task to update npm-shrinkwrap.json

fe5dfac

Add support for eslint-config-angular

9f2293d

Merge pull request #107 from codeclimate/js-eslint

2f5cabf

Update package.json

Update package.json (#112)

4952a9b

eslint-2: Vendor eslint-plugin-angular package

Merge pull request #114 from codeclimate/abh-wf-skip-minifieds

187fb76

Heuristically filter out minified files

dblandin mentioned this pull request Aug 11, 2016

add ember config for eslint #117

Closed

Aaron Craig and others added 11 commits August 11, 2016 16:49

add eslint-config-ember package

13dc1a5

Merge pull request #118 from aaroncraigongithub/eslint2/eslint-config…

e18647f

…-ember add eslint-config-ember package

Switch base image to avoid Segfault

7f3d77b

Related to #111, a Segfault occurs when we hammer STDOUT with issues. Switching from alpine to a debian-based image seems to behave better in this scenario.

Merge pull request #119 from codeclimate/gd-segfault

3cb2fa8

Switch base image to avoid Segfault

Update babel-eslint & eslint-flowtype

5a524a5

We're a bit behind on these. Flowtype in particular has new rules we weren't supporting. Looks like we hadn't actually filled in the shrinkwrap file before now, either, so that's done.

Merge pull request #121 from codeclimate/will/bump-babel-and-flowtype

0ffdd03

Update babel-eslint & eslint-flowtype

Code cleanup

7b4c106

- Update eslint configuration - Reduce complexity via temporary variable - Consistent brace style Extracted from #109

Support for ignore_path in engine config

a66ec7e

Makes it possible to use ignorePath from the CLIEngine. Useful when you are already ignoring the files you don't want to lint in different file (.e.g .gitignore).

Add --gecos "" to avoid adduser prompt

9da846b

add hapi config support

54e0d4e

hapi eslint config is based on eslint-config-hapi and eslint-plugin-hapi packages

Merge pull request #124 from elegantmonkeys/pb-eslint-2

71f21cf

add hapi config support

mhaylock reviewed Aug 25, 2016
View reviewed changes

chadxz and others added 2 commits August 29, 2016 21:05

Add eslint-config-airbnb-base as a top-level dep

49a2b84

eslint-config-airbnb-base is a transitive dependency of eslint-config-airbnb, but it is useful in its own right and should be included at the top level such that it has proper support in the eslint engine.

Merge pull request #126 from chadxz/eslint-config-airbnb-base

5018915

Add eslint-config-airbnb-base as a top-level dep

dblandin closed this Sep 12, 2016

dblandin deleted the pb-eslint-2 branch September 12, 2016 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ESlint 2.0 #92

ESlint 2.0 #92

Uh oh!

pbrisbin commented May 26, 2016 •

edited

Loading

Uh oh!

chibicode commented Jun 14, 2016

Uh oh!

dblandin commented Jun 15, 2016 •

edited

Loading

Uh oh!

dblandin commented Jun 20, 2016

Uh oh!

chibicode commented Jun 21, 2016

Uh oh!

mhaylock Aug 25, 2016

Uh oh!

pbrisbin Aug 25, 2016 •

edited

Loading

Uh oh!

dblandin commented Sep 12, 2016

Uh oh!

Uh oh!


		module.exports = function patcher(eslint) {

		meld.around(eslint.CLIEngine, 'loadPlugins', function(joinPoint) {

ESlint 2.0 #92

ESlint 2.0 #92

Uh oh!

Conversation

pbrisbin commented May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chibicode commented Jun 14, 2016

Uh oh!

dblandin commented Jun 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblandin commented Jun 20, 2016

Uh oh!

chibicode commented Jun 21, 2016

Uh oh!

mhaylock Aug 25, 2016

Choose a reason for hiding this comment

Uh oh!

pbrisbin Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dblandin commented Sep 12, 2016

Uh oh!

Uh oh!

pbrisbin commented May 26, 2016 •

edited

Loading

dblandin commented Jun 15, 2016 •

edited

Loading

pbrisbin Aug 25, 2016 •

edited

Loading