Capture stdout not in json format and raise error (#9)

Author: filipesperandio

pmd.groovy

@@ -79,6 +79,15 @@ class Config {
   }
 }
 
+def isValid(json) {
+  try {
+    new JsonSlurper().parseText(json)
+    return true
+  } catch(Exception e) {
+    return false
+  }
+}
+
 /* ********** MAIN ********** */
 
 def config = new Config(args)
@@ -94,7 +103,12 @@ Process process = builder.start()
 InputStream stdout = process.getInputStream()
 BufferedReader reader = new BufferedReader(new InputStreamReader(stdout))
 while ((line = reader.readLine()) != null) {
-  System.out.println(line)
+  if(isValid(line)) {
+    System.out.println(line)
+  } else {
+    System.err.println(line)
+    System.exit(-1)
+  }
 }
 
 process.waitForProcessOutput()

test.groovy

@@ -40,6 +40,13 @@ def abortOnBadConfig() {
   assert proc.exitValue() != 0
 }
 
+def handleBadOutput() {
+  def (proc, out, err) = execute("/usr/src/app/pmd.groovy --codeFolder=/code/test --configFile=/code/test/config.problematic_rules.json")
+
+  assert !err.toString().isEmpty()
+  assert proc.exitValue() != 0
+}
+
 def engineCheckList() {
   def engine = new JsonSlurper().parse(new File("engine.json"), "UTF-8")
   assert engine.name
@@ -74,3 +81,4 @@ dockerfileCheckList()
 sanityCheck()
 checkConfigBackwardCompatibility()
 abortOnBadConfig()
+handleBadOutput()

test/config.problematic_rules.json

@@ -0,0 +1,12 @@
+{
+  "enabled": true,
+  "channel": "beta",
+  "config": {
+    "file": "test/problematic_rules.xml",
+  },
+  "include_paths": [
+    "Main.java"
+  ]
+}
+
+

test/problematic_rules.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0"?>
+
+<ruleset name="All Java Rules"
+    xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+    <description>Every Java Rule in PMD</description>
+
+    <rule ref="rulesets/java/coupling.xml"/>
+</ruleset>
+