Avoid sending no host in test

Author: pbrisbin

lib/cc/service/safe_webhook.rb

@@ -39,10 +39,6 @@ def initialize(url)
       def ensure_safe!
         uri = URI.parse(url)
 
-        # Tests are making host-less requests which makes no sense. This keeps
-        # the spec green for the moment until I can address that.
-        return if uri.host.nil?
-
         if !allow_internal_webhooks? && internal?(uri.host)
           raise InternalWebhookError, "#{url.inspect} maps to an internal address"
         end

spec/cc/service_spec.rb

@@ -32,42 +32,42 @@
   it "post success" do
     stub_http("/my/test/url", [200, {}, '{"ok": true, "thing": "123"}'])
 
-    response = service_post("/my/test/url", { token: "1234" }.to_json, {}) do |inner_response|
+    response = service_post("http://example.com/my/test/url", { token: "1234" }.to_json, {}) do |inner_response|
       body = JSON.parse(inner_response.body)
       { thing: body["thing"] }
     end
 
     expect(response[:ok]).to eq(true)
     expect(response[:params]).to eq('{"token":"1234"}')
-    expect(response[:endpoint_url]).to eq("/my/test/url")
+    expect(response[:endpoint_url]).to eq("http://example.com/my/test/url")
     expect(response[:status]).to eq(200)
   end
 
   it "post redirect success" do
-    stub_http("/my/test/url", [307, { "Location" => "/my/redirect/url" }, '{"ok": false, "redirect": true}'])
+    stub_http("/my/test/url", [307, { "Location" => "http://example.com/my/redirect/url" }, '{"ok": false, "redirect": true}'])
     stub_http("/my/redirect/url", [200, {}, '{"ok": true, "thing": "123"}'])
 
-    response = service_post_with_redirects("/my/test/url", { token: "1234" }.to_json, {}) do |inner_response|
+    response = service_post_with_redirects("http://example.com/my/test/url", { token: "1234" }.to_json, {}) do |inner_response|
       body = JSON.parse(inner_response.body)
       { thing: body["thing"] }
     end
 
     expect(response[:ok]).to eq(true)
     expect(response[:params]).to eq('{"token":"1234"}')
-    expect(response[:endpoint_url]).to eq("/my/test/url")
+    expect(response[:endpoint_url]).to eq("http://example.com/my/test/url")
     expect(response[:status]).to eq(200)
   end
 
   it "post http failure" do
     stub_http("/my/wrong/url", [404, {}, ""])
 
-    expect { service_post("/my/wrong/url", { token: "1234" }.to_json, {}) }.to raise_error(CC::Service::HTTPError)
+    expect { service_post("http://example.com/my/wrong/url", { token: "1234" }.to_json, {}) }.to raise_error(CC::Service::HTTPError)
   end
 
   it "post some other failure" do
     stub_http("/my/wrong/url") { raise ArgumentError, "lol" }
 
-    expect { service_post("/my/wrong/url", { token: "1234" }.to_json, {}) }.to raise_error(ArgumentError)
+    expect { service_post("http://example.com/my/wrong/url", { token: "1234" }.to_json, {}) }.to raise_error(ArgumentError)
   end
 
   it "services" do