Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Conversation

@maxjacobson
Copy link
Contributor

This will make it simpler for us to identify which fields are sensitive
by type, rather than by field name.

This will make it simpler for us to identify which fields are sensitive
by type, rather than by field name.
Copy link
Contributor

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think you'll want to port this over to the shared/cc/services tree in codeclimate-ee too. We can chat IRL about why there's this duplication and how best to navigate it for this work.

@maxjacobson
Copy link
Contributor Author

makes sense, good catch. I didn't realize we weren't using the gem in that repo. I think I see what you mean and will ping you there for review

@maxjacobson maxjacobson merged commit 575ec24 into master Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants