This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Respect proxy exceptions #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate-hermes
requested review from
wilson
and removed request for
codeclimate-hermes
wfleming
force-pushed
the
will/proxy-support
branch
from
4a11334 to
c4debb4
Compare
Our usage of Faraday in this library is...unusual. Faraday does generally respect the proxy & proxy exception settings when you pass the URL directly to a `conn.post` method or anything like that, but since we set the URL within this block, that's after Faraday's logic has decided what the proxy should be, and since at that point Faraday didn't know what URL we were requesting, it used the default proxy details.
wfleming
force-pushed
the
will/proxy-support
branch
from
c4debb4 to
0cf8870
Compare
wilson
approved these changes
Nov 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our usage of Faraday in this library is...unusual.
Faraday does generally respect the proxy & proxy exception settings when
you pass the URL directly to a
conn.postmethod or anything like that,but since we set the URL within this block, that's after Faraday's logic
has decided what the proxy should be, and since at that point Faraday
didn't know what URL we were requesting, it used the default proxy
details.