This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Update existing services to ignore new constant events#25
Closed
Update existing services to ignore new constant events#25
Conversation
Contributor
Author
|
We're going to hold off on re-using quality for this purpose. No need to merge this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soon, ConstantsCreated worker events will trigger quality events that lack
previous ratings values. This PR makes it so events of this type are ignored by
the current set of services (since they can't handle them as-is).
Alternatively, we could update the services to print a more appropriate message
in this case (e.g. "Foo created as a B"). This would require changes in a few
more places and cause many new notifications to go out to users.
I decided it was better to do the smaller change (at least for now) and just
preserve existing behavior while making it possible to send these new-constant
quality events for the purposes of the FeedService.
Let me know if you'd rather I do the alternative.