Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Update existing services to ignore new constant events#25

Closed
pbrisbin wants to merge 1 commit intomasterfrom
pb-quality-as-created
Closed

Update existing services to ignore new constant events#25
pbrisbin wants to merge 1 commit intomasterfrom
pb-quality-as-created

Conversation

@pbrisbin
Copy link
Contributor

Soon, ConstantsCreated worker events will trigger quality events that lack
previous ratings values. This PR makes it so events of this type are ignored by
the current set of services (since they can't handle them as-is).

Alternatively, we could update the services to print a more appropriate message
in this case (e.g. "Foo created as a B"). This would require changes in a few
more places and cause many new notifications to go out to users.

I decided it was better to do the smaller change (at least for now) and just
preserve existing behavior while making it possible to send these new-constant
quality events for the purposes of the FeedService.

Let me know if you'd rather I do the alternative.

@pbrisbin
Copy link
Contributor Author

We're going to hold off on re-using quality for this purpose. No need to merge this code.

@pbrisbin pbrisbin closed this Jun 24, 2014
@pbrisbin pbrisbin deleted the pb-quality-as-created branch June 24, 2014 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant