Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Stash Pull Request Support#83

Merged
gdiggs merged 4 commits intomasterfrom
gd-stash-pull-requests
Sep 22, 2015
Merged

Stash Pull Request Support#83
gdiggs merged 4 commits intomasterfrom
gd-stash-pull-requests

Conversation

@gdiggs
Copy link
Contributor

@gdiggs gdiggs commented Sep 22, 2015

This will allow us to update PRs on Stash instances.

Documentation for the Stash build status API:
https://developer.atlassian.com/stash/docs/latest/how-tos/updating-build-status-for-commits.html

@codeclimate/review

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These message descriptions seem like prime candidates for DRYing across the two kinds of PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call - updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no harm in adding the @payload["message"] || part here now right? I'm going to need it soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I can add that!

@gdiggs
Copy link
Contributor Author

gdiggs commented Sep 22, 2015

@codeclimate/review ready for another look!

@pbrisbin
Copy link
Contributor

LGTM

gdiggs added a commit that referenced this pull request Sep 22, 2015
@gdiggs gdiggs merged commit 6da3e1c into master Sep 22, 2015
@gdiggs gdiggs deleted the gd-stash-pull-requests branch September 22, 2015 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants