This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Specify what is considered true for config#88
Merged
Conversation
A change in app has resulted in "0" getting written to the add_comment? field in service records, which result in undesired comments on PRs.
Contributor
Author
|
cc @codeclimate/review |
Contributor
|
LGTM |
wfleming
added a commit
that referenced
this pull request
Mar 17, 2016
Specify what is considered true for config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change in app has resulted in "0" getting written to the add_comment?
field in service records, which result in undesired comments on PRs.
I'm also seeing these value for the update_status? bit.
Digging deeper, I think we may have a general problem with how bools are being
stored here: I've tried configuring Virtus' bool casting, and looking deeper
into how we read & set things, and I'm not making much progress. This is
effectively a patch to fix affected customer behavior now, to give me some mroe
time to look more deeply into underyling problems.