This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Conversation
This reverts commit 490b779. This was a temporary patch, and shouldn't be needed.
lib/cc/service/config.rb
Outdated
| @@ -1,4 +1,4 @@ | |||
| class CC::Service::Config | |||
| include Virtus.model | |||
| include Virtus.model(coerce: true) | |||
Contributor
There was a problem hiding this comment.
I'd probably ditch this since it's the default and wasn't the issue.
Virtus pretty much depends on the type of attributes being the appopriate `Axiom` class. This led to incorrect & unexpected results in app, where other classes with the same name were getting resolved, causing quiet failures.
This is the default.
wfleming
force-pushed
the
will/bool-coercion
branch
from
aa5b542 to
66d2147
Compare
Contributor
Author
|
@pbrisbin @gordondiggs Updated. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtus depends on the type of attributes being the
appopriate
Axiomclass. This led to incorrect & unexpected results inapp, where other classes with the same name were getting resolved,
causing quiet failures.
I rolled back yesterday's temporary patch & added some small sanity tests as well.
cc @codeclimate/review @pbrisbin