array: mark the array to grow as volatile

carlosmn · Vicent Marti · commit b4d00c1d2466 · 2014-08-05T02:09:37.000+02:00
This works around strict aliasing rules letting some versions of
GCC (particularly on RHEL 6) thinking that they can skip updating the
size of the array when calculating the next element's offset.
diff --git a/src/array.h b/src/array.h
@@ -44,7 +44,7 @@ typedef git_array_t(char) git_array_generic_t;
 /* use a generic array for growth so this can return the new item */
 GIT_INLINE(void *) git_array_grow(void *_a, size_t item_size)
 {
-	git_array_generic_t *a = _a;
+	volatile git_array_generic_t *a = _a;
 	uint32_t new_size = (a->size < 8) ? 8 : a->asize * 3 / 2;
 	char *new_array = git__realloc(a->ptr, new_size * item_size);
 	if (!new_array) {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ typedef git_array_t(char) git_array_generic_t;`
`44`	`44`	`/* use a generic array for growth so this can return the new item */`
`45`	`45`	`GIT_INLINE(void ) git_array_grow(void _a, size_t item_size)`
`46`	`46`	`{`
`47`		`- git_array_generic_t *a = _a;`
	`47`	`+ volatile git_array_generic_t *a = _a;`
`48`	`48`	`uint32_t new_size = (a->size < 8) ? 8 : a->asize * 3 / 2;`
`49`	`49`	`char new_array = git__realloc(a->ptr, new_size item_size);`
`50`	`50`	`if (!new_array) {`