Conversation
README.md
Outdated
| ``` | ||
|
|
||
| By default, coverage.py will create the test coverage report at `./.coverage`. | ||
| Simply run the `codeclimate-test-reporter` to send your test report to |
There was a problem hiding this comment.
Since this is referring to running a binary, the definite article seems unnecessary?
There was a problem hiding this comment.
I would actually rethink this whole sentence: this is several sections before the important information about configuration (with the repo token, etc.), so "simply running codeclimate-test-reporter" is unlikely to actually work.
We could probably drop this sentence completely, I think: the other headings point the user in the right direction. If anything, perhaps changes should be made to other sections: maybe a section like "Uploading your coverage report" would be more instructive than "CI Integration".
6a26b04 to
2942f9f
Compare
2942f9f to
5cc7ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@codeclimate/review 🔎