Update Runner to allow error return code to be set#36
Closed
hugorodgerbrown wants to merge 1 commit intoqltysh-archive:masterfrom
yunojuno:issue_35_error_return_code
Closed
Update Runner to allow error return code to be set#36hugorodgerbrown wants to merge 1 commit intoqltysh-archive:masterfrom yunojuno:issue_35_error_return_code
hugorodgerbrown wants to merge 1 commit intoqltysh-archive:masterfrom
yunojuno:issue_35_error_return_code
Conversation
In certain circumstances (e.g. CI builds) you may not want to return a non-zero return code from the Runner.run(), as this may have unintended side-effects. This change allows the return code to be set through an environment variable called CODECLIMATE_ERROR_RETURN_CODE, which defaults to 1 (the existing behaviour). Fix for issue #35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain circumstances (e.g. CI builds) you may not want
to return a non-zero return code from the Runner.run(), as
this may have unintended side-effects. This change allows
the return code to be set through an environment
variable called CODECLIMATE_ERROR_RETURN_CODE,
which defaults to 1 (the existing behaviour).
Fix for issue #35