added support for changing the location of the .git root #66
Conversation
|
Hi @jv-dan, thanks for your contribution! I understand that this solves your problem, but I'm not completely sure if it's the right way to fix this issue. You can see the discussion in #64 I'm totally open to suggestions though, I might be wrong and this might be the right solution for the future. |
|
Interesting. Looks like two separate, yet very related issues that may in fact be both solved by being able to specify the git root explicitly. My use-case was for being able to run tests and report on them when the ACTUAL, not a dummy app, doesn't live in the root of the git repository. I'll keep an eye on the discussion and see what others have to say! |
|
Oh, thanks for clarifying it. That makes sense. I'm going to merge my changes, do you mind to rebase master with them in it? I'm sure you're going to have a small conflict. I can wait for you to release a new version of the gem, so we have both functionalities in the same release. |
Conflicts: lib/code_climate/test_reporter/git.rb
|
Sorry for holding up the release! |
|
🆒 thanks @jv-dan. Merging! |
added support for changing the location of the .git root
No description provided.