This repository was archived by the owner on May 5, 2025. It is now read-only.
Add missing indices relevant for Repo Deletion #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few very slow
DELETEqueries as part of repo deletion. The worst of those is deleting the newly created "shadow owner", which takes >1 minute.Running all the
on_deletehooks using django (which has since been fixes) has revealed that theSET NULLofCommit.authoris the culprit, as that column did not have any index previously. That is similar to theSET NULLonRepository.fork, except that query is by far not as slow, probably because of a lot less records that need to be scanned.While at it, this also fixes a django warning related to the
defaultnot being a callable, and aligns theRepository.forkSET NULLconstraint with the reality of the database.The generated SQL for the migration looks like this. Interestingly, altering the fields does not run any actual migration here, as it seems it only has an effect on the django migration state.