This repository was archived by the owner on May 5, 2025. It is now read-only.
Add Pro plan via Migration #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 90.39% 89.97% -0.43%
==========================================
Files 444 324 -120
Lines 13031 9045 -3986
Branches 2109 1599 -510
==========================================
- Hits 11780 8138 -3642
+ Misses 1131 846 -285
+ Partials 120 61 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
trent-codecov
approved these changes
Feb 3, 2025
This was referenced Feb 5, 2025
adrian-codecov
approved these changes
Feb 6, 2025
nora-shap
approved these changes
Feb 6, 2025
Member
nora-shap
left a comment
nora-shap
left a comment
There was a problem hiding this comment.
that one thing about using .update() but that's not a showstopper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeds the existing pro plan to the DB so we can use it for DEC and self-hosted by default. It also updates all owners to that plan. The migration only runs the logic if the env is enterprise.
In the process we're also creating a new variable which will set the default plan name for an owner to be the pro plan if they're enterprise so they can avoid having to create a bunch of other plans in their DB.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.