Skip to content

Conversation

@JeongDaHyeon
Copy link
Contributor

Java file name begins with a capital letter.

Pull Request Template

Description

Rename add-two-numbers.java to Add-Two-Numbers for unity.
Java files start with a capital letter.

Put check marks:

Have you made changes in README file ?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Java file name begins with a capital letter.
@welcome
Copy link

welcome bot commented Nov 13, 2020

I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉🎉 I'll take a look at it ASAP!

@GouravRusiya30 GouravRusiya30 merged commit f857240 into codedecks-in:master Nov 17, 2020
@welcome
Copy link

welcome bot commented Nov 17, 2020

Your code looks great! Congrats, I've gone ahead and merged your first pull request! Keep it up! alt text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants