Skip to content

Conversation

@jasbirrajrana
Copy link
Contributor

Pull Request Template

Description

I contribute my Leetcode solution of problem 162-Find Peak Element (Arrays). Which I solved using binary search in O(log N) time complexity.

Put checkmarks:

Have you made changes in README file?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented May 17, 2021

I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉🎉 I'll take a look at it ASAP!

@GouravRusiya30
Copy link
Member

GouravRusiya30 commented May 17, 2021

@jasbirrajrana Thanks for creating your first PR

But I can see there are some errors in the README file because of your changes. Please have a look.

@GouravRusiya30
Copy link
Member

Screenshot 2021-05-17 at 12 45 03

@jasbirrajrana
Copy link
Contributor Author

@GouravRusiya30 Take a look now :)

@GouravRusiya30
Copy link
Member

Looks good. Merging !!!

@GouravRusiya30 GouravRusiya30 merged commit b94a0e6 into codedecks-in:master May 17, 2021
@welcome
Copy link

welcome bot commented May 17, 2021

Your code looks great! Congrats, I've gone ahead and merged your first pull request! Keep it up! alt text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants