Skip to content

Conversation

@ifenil
Copy link
Contributor

@ifenil ifenil commented Oct 2, 2020

Pull Request Template

Description

A happy number is a number Starting with any positive integer, replace the number by the sum of the squares of its digits, and repeat the process until the number equals 1 if we get 1 so that number is Happy else not Happy.

Put check marks:

Have you made changes in README file ?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lokendra1704 lokendra1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Happy-Number.java, The use of HashSet can be avoided. Can you improve your solution?

@ifenil
Copy link
Contributor Author

ifenil commented Oct 2, 2020

i made changes, now can you merge it

@ifenil ifenil requested a review from lokendra1704 October 2, 2020 14:20
lokendra1704
lokendra1704 previously approved these changes Oct 2, 2020
@ifenil
Copy link
Contributor Author

ifenil commented Oct 2, 2020

I just made changes in readme file
what's happened it's asking for review again.

Copy link
Contributor

@lokendra1704 lokendra1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You repeated few names. Can you fix it?

@ifenil
Copy link
Contributor Author

ifenil commented Oct 2, 2020

Ok I check it

@lokendra1704
Copy link
Contributor

i made changes, now can you merge it

I like the new Solution 👌

| [Girish Thatte](https://github.com/girishgr8/) <br> <img src="https://github.com/girishgr8.png" width="100" height="100"> | India | Java | [Leetcode](https://leetcode.com/girish13/) <br> [Hackerrank](https://www.hackerrank.com/procoder_13) <br> [Codechef](https://www.codechef.com/procoder_13) |
| [Kevin Chittilapilly](https://github.com/KevinChittilapilly) <br> <img src="https://github.com/KevinChittilapilly.png" width="100" height="100"> | India | Java | [Leetcode](https://leetcode.com/being_kevin/) <br> [Hackerrank](https://www.hackerrank.com/ckevinvarghese11) <br> [Kaggle](https://www.kaggle.com/kevinchittilapilly) |
| [Nour Grati](https://github.com/Nour-Grati) <br> <img src="https://github.com/Nour-Grati.png" width="100" height="100"> | Tunisia | Python | [Leetcode](https://leetcode.com/nourgrati/) <br> [Hackerrank](https://www.hackerrank.com/noor_grati) <br> [Twitter](https://twitter.com/GratiNour1)
| [Avinash Trivedi](https://github.com/trivediavinash) <br> <img src="https://github.com/trivediavinash.png" width="100" height="100"> | India | C++ | [Leetcode](https://leetcode.com/avi_002/) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one too

lokendra1704
lokendra1704 previously approved these changes Oct 2, 2020
@ifenil
Copy link
Contributor Author

ifenil commented Oct 2, 2020

Ok I do it

@ifenil
Copy link
Contributor Author

ifenil commented Oct 2, 2020

now it's solved can you pls check it
And merge it

@ifenil ifenil requested a review from lokendra1704 October 2, 2020 18:55
@ifenil ifenil requested a review from lokendra1704 October 3, 2020 09:24
@ifenil
Copy link
Contributor Author

ifenil commented Oct 3, 2020

Why it's not merge yet?

@lokendra1704
Copy link
Contributor

Why it's not merge yet?

Only @GouravRusiya30 can merge the requests. He might be busy. Don't worry, It will get merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants