Integration driver mount retry logic #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/0.6.0 #543 +/- ##
=============================================
Coverage 28.4% 28.4%
=============================================
Files 34 34
Lines 2003 2003
=============================================
Hits 569 569
Misses 1373 1373
Partials 61 61Continue to review full report at Codecov.
|
codenrhoden
reviewed
May 3, 2017
api/registry/registry_integration.go
Outdated
| if err == nil { | ||
| break | ||
| } | ||
| time.Sleep(d.retryWait) |
Contributor
There was a problem hiding this comment.
My only comment is whether this Sleep() should instead be before the call to Mount inside this for loop. That way there will be delay between the initial mount attempt and the first retry. As written, if the retry wait was 1, there would be no delay between the initial attempt and the one and only retry.
Collaborator
Author
There was a problem hiding this comment.
You, sir, are correct. Fixing now.
This patch introduces the ability to configure a retry count and duration for integration driver mount operations. It satisfies a condition encountered by a user with the Ceph driver in concert with K8s
codenrhoden
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the ability to configure a retry count and duration for integration driver mount operations. It satisfies a condition encountered by a user with the Ceph driver in concert with K8s.
/cc @cduchesne