Skip to content

Conversation

@DaPandamonium
Copy link
Contributor

@DaPandamonium DaPandamonium commented Oct 21, 2024

  • ball_rect.heigh missing letter t, should be ball_rect.height

  • continue is removed here to prevent skipping other parts of the loop. In the pygame event loop, using continue immediately after pygame.display.flip() causes the rest of the loop's code to be skipped.

- ball_rect.heigh missing letter t, should be ball_rect.height

# continue is removed here to prevent skipping other parts of the loop. In the pygame event loop, using continue immediately after pygame.display.flip() causes the rest of the loop's code to be skipped.
@intelagense
Copy link
Collaborator

We fixed the typo in an different PR 👍

But let's merge this to remove the continue. Can you include edits to the MDX as well to update the instructions to match first? 🙏

@intelagense intelagense merged commit b8ca380 into codedex-io:main Oct 29, 2024
@intelagense
Copy link
Collaborator

Merged this already, but feel free to submit a new PR for the MDX changes. 😃

@intelagense intelagense added the hacktoberfest-accepted https://hacktoberfest.com/ label Oct 29, 2024
DaPandamonium added a commit to DaPandamonium/projects that referenced this pull request Oct 30, 2024
#  Removed `continue` to allow paddle movement, ball position, and other updates to occur every frame. In the original loop, there was a continue statement after checking for the start event. This statement was causing the loop to skip the remaining code every time it ran, which prevented necessary updates like paddle and ball movement, collision checks, and display refreshes. Removing this continue ensures the game loop runs each frame completely.
intelagense added a commit that referenced this pull request Nov 1, 2024
Updated the MDX for the last PR #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted https://hacktoberfest.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants