Skip to content

⚡️ Speed up function __getattr__ by 7% #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function __getattr__ by 7% #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions quantecon/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import warnings
from . import _filter

# Cache for DeprecationWarning messages to avoid repeated message construction
_warn_msg_cache: dict[str, str] = {}


__all__ = ['hamilton_filter']

Expand All @@ -16,13 +19,20 @@ def __dir__():
def __getattr__(name):
if name not in __all__:
raise AttributeError(
"`quantecon.filter` is deprecated and has no attribute "
f"'{name}'."
)

warnings.warn(f"Please use `{name}` from the `quantecon` namespace, "
"the `quantecon.filter` namespace is deprecated. You can use"
f" the following instead:\n `from quantecon import {name}`.",
category=DeprecationWarning, stacklevel=2)
"`quantecon.filter` is deprecated and has no attribute "
f"'{name}'."
)

# Optimize warning message formatting
msg = _warn_msg_cache.get(name)
if msg is None:
msg = (
f"Please use `{name}` from the `quantecon` namespace, "
"the `quantecon.filter` namespace is deprecated. You can use"
f" the following instead:\n `from quantecon import {name}`."
)
_warn_msg_cache[name] = msg

warnings.warn(msg, category=DeprecationWarning, stacklevel=2)

return getattr(_filter, name)