-
Couldn't load subscription status.
- Fork 22
Edit pyproject temporarily to remove blacklisted plugin parameters #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
@misrasaurabh1 @KRRT7 let me know if having an e2e test is a good idea, otherwise I can write some unit tests |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like
Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
PR Type
Enhancement, Tests
Description
Introduce context manager to trim pytest addopts
Wrap all test subprocess calls with stripped addopts
Temporarily modify and restore
pyproject.tomlMinor echo formatting tweak in init command
Changes walkthrough 📝
cmd_init.py
Fix echo prompt formattingcodeflash/cli_cmds/cmd_init.py
code_utils.py
Add custom_addopts context managercodeflash/code_utils/code_utils.py
custom_addoptscontext managerpyproject.tomlviatomlkit-n,-n auto,auto)test_runner.py
Wrap test execution with custom_addoptscodeflash/verification/test_runner.py
custom_addoptsfrom code_utilsexecute_test_subprocesscalls withcustom_addopts