runtime timing info even if codeflash_output assignment is missing

[aseembits93]

PR Type

Enhancement

---

Description

• Refactor runtime comment injection to use qualified_name

• Replace codeflash_output assignment checks with AST call visitor

• Propagate new qualified_name parameter through APIs

• Update tests to pass and validate qualified_name handling

---

Changes diagram

flowchart LR
  FO["function_optimizer: extract qualified_name"] --> ART["add_runtime_comments_to_generated_tests"]
  ART --> RCT["RuntimeCommentTransformer init with qualified_name"]
  RCT --> VISIT["CfoVisitor.visit_Call matches function name"]
  RCT --> CONTAINS["_contains_myfunc_call finds calls in statements"]
  RCT --> INSERT["Insert timing comments on matching lines"]

Loading

---

Changes walkthrough 📝

	Relevant files
Enhancement	edit_generated_tests.py Use qualified_name and Call visitor for runtime comments  codeflash/code_utils/edit_generated_tests.py Added qualifed_name parameter to visitor and transformer Removed multiple visit_Assign/visit_AugAssign methods Implemented visit_Call to detect function name calls Added helper _contains_myfunc_call for statement scanning +55/-98
Configuration changes	function_optimizer.py Propagate qualified_name to runtime comment API                    codeflash/optimization/function_optimizer.py Pass qualified_name to add_runtime_comments_to_generated_tests Compute qualified_name using self.function_to_optimize Adjust argument ordering for new API signature +7/-2
Tests	test_add_runtime_comments.py Update tests for qualified_name parameter                                tests/test_add_runtime_comments.py Updated tests to define and pass qualified_name Adjust all invocations of add_runtime_comments_to_generated_tests Ensure tests cover new signature and behavior +54/-43

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Parameter Typo The qualifed_name parameter is consistently misspelled without the "i", which may cause confusion or inconsistency; consider renaming it to qualified_name. def __init__(self, qualifed_name: str, source_code: str) -> None: self.source_lines = source_code.splitlines() self.name = qualifed_name.split(".")[-1] self.results: list[int] = [] # map actual line number to line number in ast Signature Mismatch Verify that the updated call to existing_tests_source_for and add_runtime_comments_to_generated_tests match their new signatures, as adding the extra qualifed_name parameter may break existing usage. qualifed_name = self.function_to_optimize.qualified_name_with_modules_from_root(self.project_root) # Add runtime comments to generated tests before creating the PR generated_tests = add_runtime_comments_to_generated_tests( qualifed_name, self.test_cfg, generated_tests, original_runtime_by_test, optimized_runtime_by_test, ) Performance Concern The code now parses and visits the AST for each function definition on the fly, which could introduce performance overhead for large test files; consider caching or optimizing these calls. def find_codeflash_output_assignments(qualifed_name: str, source_code: str) -> list[int]: tree = ast.parse(source_code) visitor = CfoVisitor(qualifed_name, source_code) visitor.visit(tree) return visitor.results

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Fix typo in parameter name Correct the parameter name typo from qualifed_name to qualified_name in both the function signature and all its usages to improve readability and consistency. codeflash/code_utils/edit_generated_tests.py [74] -def find_codeflash_output_assignments(qualifed_name: str, source_code: str) -> list[int]: +def find_codeflash_output_assignments(qualified_name: str, source_code: str) -> list[int]: Suggestion importance[1-10]: 5 __ Why: Correcting qualifed_name to qualified_name improves consistency and prevents confusion in the API.	Low
	Guard empty function name Add an early guard in _contains_myfunc_call to immediately return False when self.name is empty or unset to avoid unnecessary AST traversal. codeflash/code_utils/edit_generated_tests.py [212-232] def _contains_myfunc_call(self, node): """Recursively search for any Call node in the statement whose function is named self.name (including obj.myfunc).""" + if not self.name: + return False class Finder(cst.CSTVisitor): ... finder = Finder(self.name) node.visit(finder) return finder.found Suggestion importance[1-10]: 3 __ Why: The guard prevents unnecessary traversal when self.name is empty, but self.name is always set, so the impact is minimal.	Low

[codeflash-ai]

⚡️ Codeflash found optimizations for this PR

📄 239% (2.39x) speedup for add_runtime_comments_to_generated_tests in codeflash/code_utils/edit_generated_tests.py

⏱️ Runtime : 1.16 seconds → 341 milliseconds (best of 24 runs)

I created a new dependent PR with the suggested changes. Please review:

• ⚡️ Speed up function add_runtime_comments_to_generated_tests by 239% in PR #488 (fix-runtime-comments) #489

If you approve, it will be merged into this PR (branch fix-runtime-comments).

[aseembits93]

have a newer one with more bugfixes